Skip to content

NHSO-0000: Fix security hotspot. #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThomasPedleyNHS merged 1 commit into from
Jul 14, 2026
Merged

NHSO-0000: Fix security hotspot. #387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/continuous-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ jobs:

- name: Install node
run: |
wget -q -O - https://dl.google.com/linux/linux_signing_key.pub | sudo apt-key add -
curl -sL https://deb.nodesource.com/setup_24.x | sudo -E bash -
curl --proto "=https" --tlsv1.2 -sSf -L https://dl.google.com/linux/linux_signing_key.pub | sudo apt-key add -
curl --proto "=https" --tlsv1.2 -sSf -L https://deb.nodesource.com/setup_24.x | sudo -E bash -
sudo apt-get install -y nodejs

- name: Upgrade python packaging tools
Expand Down
12 changes: 6 additions & 6 deletions sandbox/controllers/Pets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ module.exports.createPets = function createPets (req, res, next) {
.then(function (response) {
utils.writeJson(res, response);
})
.catch(function (response) {
utils.writeJson(res, response);
.catch(function (error_) {
utils.writeJson(res, error_);
});
};

Expand All @@ -18,8 +18,8 @@ module.exports.listPets = function listPets (req, res, next, limit) {
.then(function (response) {
utils.writeJson(res, response);
})
.catch(function (response) {
utils.writeJson(res, response);
.catch(function (error_) {
utils.writeJson(res, error_);
});
};

Expand All @@ -28,7 +28,7 @@ module.exports.showPetById = function showPetById (req, res, next, petId) {
.then(function (response) {
utils.writeJson(res, response);
})
.catch(function (response) {
utils.writeJson(res, response);
.catch(function (error_) {
utils.writeJson(res, error_);
});
};
4 changes: 2 additions & 2 deletions sandbox/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict';

const path = require('path');
const http = require('http');
const path = require('node:path');
const http = require('node:http');
const express = require('express');
const oasTools = require('oas-tools');
const fs = require('node:fs');
Expand Down
2 changes: 1 addition & 1 deletion scripts/tag-versions.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ VERSION=$(poetry run python scripts/calculate_version.py)

GIT_BRANCH=$(git rev-parse --abbrev-ref HEAD)

if [ "$GIT_BRANCH" = 'master' ]; then
if [[ "$GIT_BRANCH" = 'master' ]]; then
git config credential.helper 'cache --timeout 120'
git config user.email "<email>"
git config user.name "Marvin (Automated)"
Expand Down