CCM-20032: Letter Variant SupplierId Not Honoured#634
Open
nhsd-david-wass wants to merge 6 commits into
Open
Conversation
nhsd-david-wass
force-pushed
the
feature/CCM-20032-Letter-Variant_SupplierId
branch
2 times, most recently
from
1086bb7 to
30c7f1f
Compare
nhsd-david-wass
force-pushed
the
feature/CCM-20032-Letter-Variant_SupplierId
branch
8 times, most recently
from
2b34aa3 to
197426d
Compare
stevebux
reviewed
Jul 1, 2026
stevebux
reviewed
Jul 1, 2026
stevebux
previously approved these changes
Jul 1, 2026
nhsd-david-wass
force-pushed
the
feature/CCM-20032-Letter-Variant_SupplierId
branch
from
c26a423 to
b59f07c
Compare
nhsd-david-wass
force-pushed
the
feature/CCM-20032-Letter-Variant_SupplierId
branch
from
b59f07c to
c9491d1
Compare
|
stevebux
previously approved these changes
Jul 16, 2026
Comment on lines
+396
to
+398
| console.log( | ||
| `Error processing allocation of record ${record.messageId}: ${error}`, | ||
| ); |
Contributor
There was a problem hiding this comment.
Was this just for debugging purposes, do we still need it if we are also logging it
RossFaulds171
previously approved these changes
Jul 16, 2026
nhsd-david-wass
dismissed stale reviews from RossFaulds171 and stevebux
via
2b2b631
nhsd-david-wass
force-pushed
the
feature/CCM-20032-Letter-Variant_SupplierId
branch
from
c9491d1 to
2b2b631
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
DT3-Specific Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.