fix(server): bind to localhost by default - #584
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe server CLI now binds to IPv4 localhost by default. Comments state that external exposure requires an explicit ChangesServer bind configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The server will bind to localhost by default, reducing unintended remote exposure while preserving external access through an explicit --host value. No actionable merge-blocking risk remains after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. Comment |
Signed-off-by: Aaron Elijah Mars <61592645+aaronjmars@users.noreply.github.com>
949be12 to
16a0539
Compare
|
Thanks for raising this. This changes the deployment behavior of I've opened #596 so we can decide what the default should be and account for those paths together. I'm going to close this PR for now. |
Summary\n\n- Change the standalone switchyard-server default bind address from 0.0.0.0 to 127.0.0.1.\n- Keep all-interface exposure available through an explicit --host value.\n\nThis is a project-improvement contribution following NVIDIA PSIRT ticket 6648053. It is intentionally separate from the closed security report and does not claim that the documented demo server is a security bug.\n\n## Testing\n\n- git diff --check\n- Cargo tests unavailable because Cargo is not installed in this environment.
Summary by CodeRabbit