Skip to content

fix(policy): reject unknown endpoint security modes - #3187

Draft
2000krysztof wants to merge 1 commit into
NVIDIA:mainfrom
2000krysztof:fix/fail-closed-policy-enums
Draft

fix(policy): reject unknown endpoint security modes#3187
2000krysztof wants to merge 1 commit into
NVIDIA:mainfrom
2000krysztof:fix/fail-closed-policy-enums

Conversation

@2000krysztof

@2000krysztof 2000krysztof commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Summary

WIP Until Monday

Validate TLS, enforcement, and access values across policy and provider profile ingress, and prevent runtime parsing from falling back to audit for unknown enforcement values.

Related Issue

Closes #3046

Changes

  • Added shared validation for endpoint tls, enforcement, and access strings.
  • Rejects unknown values with actionable errors listing accepted values.
  • Applies validation to sandbox policies and provider profiles.
  • Prevents malformed enforcement values such as enforc from falling back to audit mode.
  • Added defensive runtime rejection for invalid endpoint modes.
  • Returns gRPC INVALID_ARGUMENT before invalid policies are persisted or activated.
  • Added regression tests for policy, provider-profile, gateway, and runtime validation.
  • Documented the accepted values and fail-closed behavior.
  • No protobuf or generated SDK types changed yet. Secound commit will be made to address that (WIP)

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Closes NVIDIA#3046

Validate TLS, enforcement, and access values across policy and provider profile ingress, and prevent runtime parsing from falling back to audit for unknown enforcement values.

Signed-off-by: Krzysztof Malczuk <kmalczuk@redhat.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 4, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@johntmyers
johntmyers marked this pull request as draft September 4, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(policy)!: make security-sensitive policy values fail closed

1 participant