[TRTLLM-15078][test] Prune non-Llama-3.1-8B Llama tests - #17392
[TRTLLM-15078][test] Prune non-Llama-3.1-8B Llama tests#17392xinhe-nv wants to merge 18 commits into
Conversation
|
@coderabbitai review the change, we need to retire llama tests, if the test is must have, please show me in a table. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThe PR removes obsolete model accuracy, performance, disaggregated-serving, Ray, LoRA, and API test coverage. It updates integration manifests and retargets selected unit tests from TinyLlama to Llama 3.1 8B Instruct. ChangesTest matrix cleanup
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1⚔️ Resolve merge conflicts 💡
🧪 Generate unit tests (beta)
Comment |
85d9aab to
8876f42
Compare
Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com> Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: YihuiLu512 <269394165+YihuiLu512@users.noreply.github.com> Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
temperature is typed as float but set to None in the greedy-sampling branch of sampler_strategy.py. Suppress the assignment error at the module level in pyproject.toml pending an annotation fix upstream. Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
…list entries Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
…move deleted test file refs Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
…17117) Signed-off-by: Mingyang Hao <200044211+mingyangHao@users.noreply.github.com> Co-authored-by: Mingyang Hao <200044211+mingyangHao@users.noreply.github.com> Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
NVIDIA#17785) Signed-off-by: Brian Nguyen <brnguyen@nvidia.com> Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
… remove stale waives Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
…ator from l0_h100.yml Function does not exist in test_disaggregated.py. Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Revert flashinfer.py and pyproject.toml to upstream/main state. Keep minimal type: ignore[assignment] on sampler_strategy.py:331 for the bindings-less pre-commit lightweight check (mypy #19081). Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Remove the lightweight-mypy workaround; upstream CI runs with torch stubs where mypy resolves Strategy correctly and the [assignment] suppression is not needed. Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
temperature is typed as float from match-case pattern capture but set to None in the greedy case (mypy issue #19081). Add type: ignore on the assignment until the lightweight check resolves Strategy correctly. Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
|
/bot run |
|
PR_Github #66723 [ run ] triggered by Bot. Commit: |
|
PR_Github #66723 [ run ] completed with state
|
Dev Engineer Review
test_llm.pygolden outputs.QA Engineer Review
Test code changed across accuracy, disaggregated serving, E2E, KV-cache, LLM API, Ray, MPI, LoRA, sampler, and AutoDeploy areas.
Removed or modified tests include accuracy classes, disaggregated-serving functions, Ray and MPI examples, KV-cache tests, LLM API tests, LoRA helpers, sampler tests, and model-path fixtures. Several retained tests now use Llama-3.1-8B-Instruct.
Affected manifests:
tests/integration/test_lists/qa/llm_function_core.txttests/integration/test_lists/qa/llm_spark_core.txttests/integration/test_lists/qa/llm_spark_func.ymltests/integration/test_lists/qa/llm_spark_perf.ymltests/integration/test_lists/test-db/l0_a10.ymltests/integration/test_lists/test-db/l0_a100.ymltests/integration/test_lists/test-db/l0_b200.ymltests/integration/test_lists/test-db/l0_dgx_b200.ymltests/integration/test_lists/test-db/l0_dgx_h100.ymltests/integration/test_lists/test-db/l0_dgx_h200.ymltests/integration/test_lists/test-db/l0_gb200_multi_gpus.ymltests/integration/test_lists/test-db/l0_h100.ymltests/integration/test_lists/test-db/l0_l40s.ymltests/integration/test_lists/test-db/l0_sanity_check.ymltests/integration/test_lists/waives.txtCBTS coverage data is unavailable. Verdict: needs follow-up.
Description
The background is https://docs.google.com/spreadsheets/d/17qLRr5oQESqn1rT9LrIUnpjvhH8wcC59273YEPT9k44/edit?gid=177162358#gid=177162358
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.