Skip to content

[None][chore] BREAKING: Test KV cache manager v2 as the default - #17495

Draft
yizhang-nv wants to merge 2 commits into
NVIDIA:mainfrom
yizhang-nv:codex/kvcm-v2-default-true-ci
Draft

[None][chore] BREAKING: Test KV cache manager v2 as the default#17495
yizhang-nv wants to merge 2 commits into
NVIDIA:mainfrom
yizhang-nv:codex/kvcm-v2-default-true-ci

Conversation

@yizhang-nv

Copy link
Copy Markdown
Member

@coderabbitai summary

Description

This draft PR changes KvCacheConfig.use_kv_cache_manager_v2 from the "auto" default to True and updates the corresponding declaration test.

The purpose is to run the full pre-merge CI suite and identify failures or compatibility gaps that are currently avoided by the automatic fallback logic. This is an experimental PR and is not intended for merge until the CI fallout has been reviewed.

Test Coverage

  • python3 scripts/generate_llm_args_golden_manifest.py passed; the manifest did not change because it does not record field defaults.
  • pytest -s tests/unittest/llmapi/test_llm_args.py: 278 passed, 8 failed. Seven failures are direct fallout from bypassing the "auto" fallback: the no-preference fallback, three incompatible disaggregated-serving cases, two DEFAULT-backend environment routes, and the no-checkpoint-loader path. The remaining test_runtime_sizes failure came from the container's unrelated Triton API mismatch (triton_kernels.tensor.bitwidth).
  • Two additional targeted tests failed as expected: Kimi without a V2 preference now selects V2 instead of the mixed manager, and two-model GPT-OSS Eagle3 now raises the explicit-V2 incompatibility error instead of falling back to V1.
  • Full pre-merge CI will be triggered with fail-fast disabled so failures across all stages can be observed.

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@yizhang-nv

Copy link
Copy Markdown
Member Author

/bot run --disable-fail-fast

@yizhang-nv yizhang-nv changed the title [None][chore] Test KV cache manager v2 as the default [None][chore] BREAKING: Test KV cache manager v2 as the default Aug 11, 2026
@yizhang-nv yizhang-nv added the api-breaking Accepted LLM API contract change that is backwards-incompatible label Aug 11, 2026
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #65256 [ run ] triggered by Bot. Commit: 2595749 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #65256 [ run ] completed with state SUCCESS. Commit: 2595749
/LLM/main/L0_MergeRequest_PR pipeline #53032 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@yizhang-nv

Copy link
Copy Markdown
Member Author

/bot run --disable-fail-fast

@yizhang-nv
yizhang-nv force-pushed the codex/kvcm-v2-default-true-ci branch from 8a8cd95 to e289dd8 Compare August 14, 2026 07:16
@yizhang-nv

Copy link
Copy Markdown
Member Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #66215 [ run ] triggered by Bot. Commit: e289dd8 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #66215 [ run ] completed with state SUCCESS. Commit: e289dd8
/LLM/main/L0_MergeRequest_PR pipeline #53884 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@yizhang-nv

Copy link
Copy Markdown
Member Author

/bot run --disable-fail-fast --disable-reuse-test --stage-list "A10-PyTorch-1, A10-PyTorch-2, A10-PyTorch-3, A30-AutoDeploy-1, CPU-Generic-arm-1, CPU-Generic-x86-1, DGX_B200-AutoDeploy-1, DGX_B200-PyTorch-1, DGX_B200-PyTorch-2, DGX_B200-PyTorch-3, DGX_B200-PyTorch-4, DGX_B200-PyTorch-5, DGX_B200-PyTorch-6, DGX_B200-PyTorch-7, DGX_B200-PyTorch-8, DGX_B200-PyTorch-9, DGX_H100-PyTorch-1, DGX_H100-PyTorch-2, DGX_H100-PyTorch-3, DGX_H100-PyTorch-4, DGX_H100-PyTorch-5, DGX_H100-PyTorch-6, H100_PCIe-AutoDeploy-1, H100_PCIe-PyTorch-Ray-1, DGX_B200-PyTorch-Post-Merge-1, DGX_B200-PyTorch-Post-Merge-2, DGX_H100-PyTorch-Post-Merge-1, DGX_H100-PyTorch-Post-Merge-2"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #66680 [ run ] triggered by Bot. Commit: 1db4b89 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #66680 [ run ] completed with state SUCCESS. Commit: 1db4b89
/LLM/main/L0_MergeRequest_PR pipeline #54296 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@yiqingy0 yiqingy0 added the ci: post-merge approved Approved by TRT-LLM CI approvers for broad post-merge CI requests label Aug 17, 2026
@yizhang-nv
yizhang-nv force-pushed the codex/kvcm-v2-default-true-ci branch 2 times, most recently from 6e62635 to 39ed067 Compare August 17, 2026 15:27
@yizhang-nv

Copy link
Copy Markdown
Member Author

/bot run --disable-fail-fast --disable-reuse-test --extra-stage "Post-Merge"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #66784 [ ] completed with state FAILURE. Commit: ``

Link to invocation

@yizhang-nv

Copy link
Copy Markdown
Member Author

/bot help

@github-actions

Copy link
Copy Markdown

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental) --high-priority]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Supports wildcard * for pattern matching (e.g., "*PerfSanity*" matches all stages containing PerfSanity). Examples: "A10-PyTorch-1, xxx", "PerfSanity". The patterns "*", "*Post-Merge*", and "*PerfSanity*", including equivalent escaped or repeated-star forms and their use in comma-separated lists, require the ci: post-merge approved PR label. Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Requires the ci: full pre-merge approved label on the PR (ask a member of NVIDIA/trt-llm-ci-approvers). Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline. Requires the ci: full pre-merge approved label on the PR (ask a member of NVIDIA/trt-llm-ci-approvers).

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline. Requires the ci: post-merge approved PR label applied by an active member of NVIDIA/trt-llm-ci-approvers. The approval label remains in place when new commits are pushed.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Supports wildcard * for pattern matching. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx", --extra-stage "Post-Merge". The patterns "*", "*Post-Merge*", and "*PerfSanity*", including equivalent escaped or repeated-star forms and their use in comma-separated lists, require the ci: post-merge approved PR label.

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

--high-priority (OPTIONAL) : Run the pipeline with high priority. This option is restricted to authorized users only and will route the job to a high-priority queue.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@yizhang-nv

Copy link
Copy Markdown
Member Author

/bot run --post-merge --disable-fail-fast --disable-reuse-test

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #66943 [ run ] triggered by Bot. Commit: 39ed067 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #66943 [ run ] completed with state FAILURE. Commit: 39ed067
/LLM/main/L0_MergeRequest_PR pipeline #54495 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Enable KV cache manager V2 and the Python cache transceiver by default, and migrate supported examples and tests to the V2 path.

Keep explicit V1 and C++ settings only for legacy transport, compatibility, and dedicated coverage.

Signed-off-by: Yi Zhang <187001205+yizhang-nv@users.noreply.github.com>
@yizhang-nv
yizhang-nv force-pushed the codex/kvcm-v2-default-true-ci branch from 39ed067 to 9c5c909 Compare August 18, 2026 09:38
Signed-off-by: Yi Zhang <187001205+yizhang-nv@users.noreply.github.com>
@yizhang-nv

Copy link
Copy Markdown
Member Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #67082 [ run ] triggered by Bot. Commit: 910065d Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-breaking Accepted LLM API contract change that is backwards-incompatible ci: full pre-merge approved ci: post-merge approved Approved by TRT-LLM CI approvers for broad post-merge CI requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants