Skip to content

[None][infra] Allow normal review for waiver updates - #17547

Merged
chzblych merged 1 commit into
NVIDIA:mainfrom
chzblych:agent/waives-normal-review
Aug 12, 2026
Merged

[None][infra] Allow normal review for waiver updates#17547
chzblych merged 1 commit into
NVIDIA:mainfrom
chzblych:agent/waives-normal-review

Conversation

@chzblych

@chzblych chzblych commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Description

Remove the code-owner assignment for tests/integration/test_lists/waives.txt by giving the path an explicit ownerless CODEOWNERS entry.

Waiver-only PRs will continue to follow the repository's normal approval requirements, but they will no longer require an approval from @NVIDIA/trt-llm-devs, @NVIDIA/trt-llm-qa-function, or @NVIDIA/trt-llm-infra-devs. PRs that modify other owned paths still require the corresponding code-owner approval.

Test Coverage

  • git diff --check
  • Verified that the exact waives.txt path resolves to an ownerless CODEOWNERS entry.
  • No runtime tests were run because this is a CODEOWNERS-only governance change.

PR Checklist

  • PR description clearly explains what and why.
  • PR follows TRT-LLM coding guidelines to the best of my knowledge.
  • No new code path or API change is introduced.
  • No new dependencies are introduced.
  • CODEOWNERS is the only modified file.
  • Documentation and the architecture diagram are not affected.
  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, comment /bot help.

Dev Engineer Review

  • Updated .github/CODEOWNERS.
  • Added an explicit ownerless rule for tests/integration/test_lists/waives.txt.
  • Waiver-only pull requests now follow normal repository approval requirements.
  • Other owned paths retain their existing code-owner requirements.
  • git diff --check passed.
  • No runtime tests were run.

QA Engineer Review

  • No test files changed.
  • The change only updates CODEOWNERS.
  • Verdict: sufficient.

Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
@chzblych
chzblych marked this pull request as ready for review August 12, 2026 08:48
@chzblych
chzblych requested review from a team as code owners August 12, 2026 08:48
@chzblych
chzblych requested review from mlefeb01 and mzweilz August 12, 2026 08:48
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9c427b7b-bdb6-40c3-8eae-7e28eb51a73c

📥 Commits

Reviewing files that changed from the base of the PR and between a2e0fba and 94d0b1e.

📒 Files selected for processing (1)
  • .github/CODEOWNERS

Walkthrough

The CODEOWNERS rule for /tests/integration/test_lists/waives.txt now includes standard review requirements and removes its explicit team assignments.

Changes

Waiver test-list ownership

Layer / File(s) Summary
Update waiver test-list review rule
.github/CODEOWNERS
Adds a review-requirements comment and removes explicit multi-team ownership for the waiver test list.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: tburt-nv, zhanruisunch, dpitman-nvda

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the infrastructure change that allows normal review for waiver updates.
Description check ✅ Passed The description explains the CODEOWNERS change, its impact, validation steps, and checklist status.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@chzblych
chzblych merged commit 7f62928 into NVIDIA:main Aug 12, 2026
12 checks passed
@chzblych
chzblych deleted the agent/waives-normal-review branch August 12, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants