[None][infra] Allow normal review for waiver updates - #17547
Merged
Conversation
Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe CODEOWNERS rule for ChangesWaiver test-list ownership
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ZhanruiSunCh
approved these changes
Aug 12, 2026
juney-nvidia
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the code-owner assignment for
tests/integration/test_lists/waives.txtby giving the path an explicit ownerless CODEOWNERS entry.Waiver-only PRs will continue to follow the repository's normal approval requirements, but they will no longer require an approval from
@NVIDIA/trt-llm-devs,@NVIDIA/trt-llm-qa-function, or@NVIDIA/trt-llm-infra-devs. PRs that modify other owned paths still require the corresponding code-owner approval.Test Coverage
git diff --checkwaives.txtpath resolves to an ownerless CODEOWNERS entry.PR Checklist
GitHub Bot Help
To see a list of available CI bot commands, comment
/bot help.Dev Engineer Review
.github/CODEOWNERS.tests/integration/test_lists/waives.txt.git diff --checkpassed.QA Engineer Review
CODEOWNERS.