[https://nvbugs/6140408][chore] Unwaive DeepSeekV3Lite test_nvfp4_4gpus CUTLASS pp4 and CUTEDSL tp2pp2 - #17569
Conversation
…us CUTLASS pp4 and CUTEDSL tp2pp2 Both cases were waived under https://nvbugs/6427411 (PP sampler regressions), which is fixed and closed. The CUTLASS pp4 case was verified at ToT (v1.3.0rc25) on 4x RTX PRO 6000 Blackwell (SM120): GSM8K 64.63 vs threshold 60.51 (reference 63.71). The CUTEDSL tp2pp2 case only runs on SM100/103 and is covered by GB200 post-merge. Signed-off-by: Michal Guzek <mguzek@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughThe integration waiver list replaces a DeepSeekV3Lite NVFP4 CUTEDSL configuration with a CUTLASS ChangesWaiver configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
|
/bot run |
|
PR_Github #65641 [ run ] triggered by Bot. Commit: |
|
PR_Github #65641 [ run ] completed with state
|
|
/bot run |
|
PR_Github #65694 [ run ] triggered by Bot. Commit: |
|
PR_Github #65694 [ run ] completed with state |
Dev Engineer Review
tp2pp2case.pp4waiver entry withfp8kv=Falseand Torch compile enabled.QA Engineer Review
tests/integration/test_lists/waives.txtchanged.tp2pp2waiver.pp4waiver.Verdict: needs follow-up
Description
Both cases were waived under https://nvbugs/6427411 (PP sampler regressions), which is fixed and closed. The CUTLASS pp4 case was verified at ToT (
v1.3.0rc25) on 4x RTX PRO 6000 Blackwell (SM120): GSM8K64.63vs threshold60.51(reference63.71). The CUTEDSL tp2pp2 case only runs on SM100/103 and is covered by GB200 post-merge.Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.