[https://nvbugs/6578853][test] Unwaive layer-wise benchmarks performance alignment test - #17963
Conversation
|
/bot run |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe integration test waiver list no longer contains the waived ChangesTest waiver cleanup
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change only re-enables an existing performance-alignment test, with no actionable merge-blocking risk remaining after normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #67378 [ run ] triggered by Bot. Commit: |
|
PR_Github #67378 [ run ] completed with state |
Dev Engineer Review
unittest/tools/test_layer_wise_benchmarks.py::test_performance_alignment[1].waives.txtformat.QA Engineer Review
tests/integration/test_lists/waives.txt.unittest/tools/test_layer_wise_benchmarks.py::test_performance_alignment[1].test-db/orqa/files were modified.Description
Removes the waive for
unittest/tools/test_layer_wise_benchmarks.py::test_performance_alignment[1].The case was waived under https://nvbugs/6578853 by the automated waive PR #17443 (pre-merge 52592) on 08/09. This PR drops that line so the case runs again in pre-merge and the current state of the bug is validated against ToT rather than staying permanently skipped.
The test is the world-size-1 leaf of the layer-wise benchmarks performance-alignment flow: it runs
examples/layer_wise_benchmarks/sample_performance_alignment.shagainst the pinnedDeepSeek-V3-Lite/nvfp4_moe_onlycheckpoint (collect/mark nsys passes,run.shreplay, thenparse_e2e.py/parse.py/correlation.py), followed by a standaloneparse.pyinvocation.Test Coverage
unittest/tools/test_layer_wise_benchmarks.py::test_performance_alignment[1]— already listed intests/integration/test_lists/test-db/l0_b200.yml, so removing the waive re-enables it in theDGX_B200-PyTorch-*pre-merge stages. No other change is needed to schedule it.Note that the module-scoped
require_nsys_cuda_tracingfixture still skips the whole file on nodes where nsys cannot record CUDA activity (CUDA forward-compatibility mode, https://nvbugs/6162541), and@skip_pre_blackwellstill gates the case to SM100+.PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.🤖 Generated with Claude Code