Skip to content

[https://nvbugs/6578853][test] Unwaive layer-wise benchmarks performance alignment test - #17963

Merged
kaiyux merged 1 commit into
NVIDIA:mainfrom
kaiyux:user/kaiyu/bug_lw_bench_6578853
Aug 19, 2026
Merged

[https://nvbugs/6578853][test] Unwaive layer-wise benchmarks performance alignment test#17963
kaiyux merged 1 commit into
NVIDIA:mainfrom
kaiyux:user/kaiyu/bug_lw_bench_6578853

Conversation

@kaiyux

@kaiyux kaiyux commented Aug 19, 2026

Copy link
Copy Markdown
Member

Dev Engineer Review

  • Removed the waive entry for unittest/tools/test_layer_wise_benchmarks.py::test_performance_alignment[1].
  • The change uses the existing waives.txt format.
  • The scope is limited to the world-size-1 test.
  • No code, API, performance, or error-handling changes are included.
  • No duplicate or invalid test entry is introduced.

QA Engineer Review

  • Modified tests/integration/test_lists/waives.txt.
  • Removed the waive and associated skip reference for unittest/tools/test_layer_wise_benchmarks.py::test_performance_alignment[1].
  • No test-db/ or qa/ files were modified.
  • The test remains covered by the existing test configuration and retains its nsys CUDA tracing and SM100+ conditions.
  • Verdict: needs follow-up because CBTS coverage data is unavailable.

Description

Removes the waive for unittest/tools/test_layer_wise_benchmarks.py::test_performance_alignment[1].

The case was waived under https://nvbugs/6578853 by the automated waive PR #17443 (pre-merge 52592) on 08/09. This PR drops that line so the case runs again in pre-merge and the current state of the bug is validated against ToT rather than staying permanently skipped.

The test is the world-size-1 leaf of the layer-wise benchmarks performance-alignment flow: it runs examples/layer_wise_benchmarks/sample_performance_alignment.sh against the pinned DeepSeek-V3-Lite/nvfp4_moe_only checkpoint (collect/mark nsys passes, run.sh replay, then parse_e2e.py / parse.py / correlation.py), followed by a standalone parse.py invocation.

Test Coverage

unittest/tools/test_layer_wise_benchmarks.py::test_performance_alignment[1] — already listed in tests/integration/test_lists/test-db/l0_b200.yml, so removing the waive re-enables it in the DGX_B200-PyTorch-* pre-merge stages. No other change is needed to schedule it.

Note that the module-scoped require_nsys_cuda_tracing fixture still skips the whole file on nodes where nsys cannot record CUDA activity (CUDA forward-compatibility mode, https://nvbugs/6162541), and @skip_pre_blackwell still gates the case to SM100+.

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

🤖 Generated with Claude Code

Signed-off-by: Kaiyu Xie <26294424+kaiyux@users.noreply.github.com>
@kaiyux

kaiyux commented Aug 19, 2026

Copy link
Copy Markdown
Member Author

/bot run

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9956d54e-adae-4f47-9795-c43ce84ea24a

📥 Commits

Reviewing files that changed from the base of the PR and between ee197dc and 5697fc8.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The integration test waiver list no longer contains the waived test_performance_alignment[1] entry tracked by NVBUG 6578853.

Changes

Test waiver cleanup

Layer / File(s) Summary
Remove performance alignment waiver
tests/integration/test_lists/waives.txt
Removes the skip waiver for test_performance_alignment[1].

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 5697f

This change only re-enables an existing performance-alignment test, with no actionable merge-blocking risk remaining after normal checks and review.

Possibly related PRs

Suggested reviewers: xinhe-nv

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the NVBugs issue, test-related change, and removal of the layer-wise benchmarks waive.
Description check ✅ Passed The description explains the reason, scope, affected test, coverage, existing gates, and checklist status.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #67378 [ run ] triggered by Bot. Commit: 5697fc8 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #67378 [ run ] completed with state SUCCESS. Commit: 5697fc8
/LLM/main/L0_MergeRequest_PR pipeline #54887 completed with status: 'SUCCESS'

CI Report

Link to invocation

@kaiyux
kaiyux enabled auto-merge (squash) August 19, 2026 10:10
@kaiyux
kaiyux merged commit 14ef94c into NVIDIA:main Aug 19, 2026
13 checks passed
@kaiyux
kaiyux deleted the user/kaiyu/bug_lw_bench_6578853 branch August 19, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants