[https://nvbugs/6602094][test] Unwaive RocketKV model tests - #18010
Conversation
Remove the TRTLLM and VANILLA Llama 3.1 RocketKV skips after repeated GB300 passes and local B200 validation. Signed-off-by: Fanrong Li <23290157+lfr-0531@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe integration test waiver list no longer skips the TRTLLM and VANILLA RocketKV Llama 3.1 model tests. ChangesRocketKV waiver cleanup
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change restores regular CI coverage for two RocketKV model tests without changing product code or APIs; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run --disable-fail-fast |
|
PR_Github #67781 [ run ] triggered by Bot. Commit: |
|
PR_Github #67781 [ run ] completed with state |
|
/bot run --stage-list "GB300-4_GPUs-PyTorch-Post-Merge-1" |
|
PR_Github #67812 [ run ] triggered by Bot. Commit: |
|
PR_Github #67812 [ run ] completed with state
|
|
I reran these tests on GB300 multiple times, and I cannot reproduce the failure. |
|
/bot run --disable-fail-fast |
|
PR_Github #68047 [ run ] triggered by Bot. Commit: |
|
PR_Github #68047 [ run ] completed with state |
ZhanruiSunCh
left a comment
There was a problem hiding this comment.
LGTM for infra part. Verified both unwaived test_model parametrizations (TRTLLM and VANILLA) passed in build #55258.
Dev Engineer Review
tests/integration/test_lists/waives.txt.QA Engineer Review
test-db/orqa/files were modified.waives.txt.tests/integration/test_lists/test-db/l0_b200.ymltests/integration/test_lists/qa/llm_function_core.txtDescription
NVBug 6602094 tracked a one-off timeout in the RocketKV Llama 3.1 model tests. Subsequent repeated runs on 4x GB300 passed for both the TRTLLM and VANILLA attention backends, and the VANILLA case also passed 10 consecutive local B200 runs.
Remove the two SKIP entries so both RocketKV configurations return to regular CI coverage. This changes only the waiver list and has no product-code or API impact.
Test Coverage
python3 scripts/check_test_list.py --validate --check-duplicate-waives:OK: 2065 unique test entries validated.pre-commit run --files tests/integration/test_lists/waives.txt: passed in a Python 3.12 development container.test_model[VANILLA-llama-3.1-model/Llama-3.1-8B-Instruct-pytorch]: 10/10 passed locally on B200.PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant change.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available bot commands, please comment
/bot help.