Skip to content

[https://nvbugs/6602094][test] Unwaive RocketKV model tests - #18010

Merged
lfr-0531 merged 1 commit into
NVIDIA:mainfrom
lfr-0531:user/fanrongl/fix-nvbug-6602094-rocketkv
Aug 21, 2026
Merged

[https://nvbugs/6602094][test] Unwaive RocketKV model tests#18010
lfr-0531 merged 1 commit into
NVIDIA:mainfrom
lfr-0531:user/fanrongl/fix-nvbug-6602094-rocketkv

Conversation

@lfr-0531

@lfr-0531 lfr-0531 commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Dev Engineer Review

  • Removed the two RocketKV Llama 3.1 skip entries from tests/integration/test_lists/waives.txt.
  • Restores TRTLLM and VANILLA attention backend tests to regular CI coverage.
  • The change has no product-code or API impact.
  • Repeated GB300 runs and local B200 validation support removal of the one-off timeout waivers.

QA Engineer Review

  • No test-db/ or qa/ files were modified.
  • Removed the TRTLLM and VANILLA RocketKV Llama 3.1 entries from waives.txt.
  • The RocketKV test is present in:
    • tests/integration/test_lists/test-db/l0_b200.yml
    • tests/integration/test_lists/qa/llm_function_core.txt
  • Verdict: sufficient.

Description

NVBug 6602094 tracked a one-off timeout in the RocketKV Llama 3.1 model tests. Subsequent repeated runs on 4x GB300 passed for both the TRTLLM and VANILLA attention backends, and the VANILLA case also passed 10 consecutive local B200 runs.

Remove the two SKIP entries so both RocketKV configurations return to regular CI coverage. This changes only the waiver list and has no product-code or API impact.

Test Coverage

  • python3 scripts/check_test_list.py --validate --check-duplicate-waives: OK: 2065 unique test entries validated.
  • pre-commit run --files tests/integration/test_lists/waives.txt: passed in a Python 3.12 development container.
  • test_model[VANILLA-llama-3.1-model/Llama-3.1-8B-Instruct-pytorch]: 10/10 passed locally on B200.
  • Both VANILLA and TRTLLM configurations passed repeated Repair Bot runs on 4x GB300.

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant change.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available bot commands, please comment /bot help.

Remove the TRTLLM and VANILLA Llama 3.1 RocketKV skips after repeated GB300 passes and local B200 validation.

Signed-off-by: Fanrong Li <23290157+lfr-0531@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1f3aa9b4-7737-498a-b373-de4d757fd419

📥 Commits

Reviewing files that changed from the base of the PR and between 96a143e and 82396cb.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The integration test waiver list no longer skips the TRTLLM and VANILLA RocketKV Llama 3.1 model tests.

Changes

RocketKV waiver cleanup

Layer / File(s) Summary
Remove RocketKV test waivers
tests/integration/test_lists/waives.txt
Removed the skip waivers for the TRTLLM and VANILLA RocketKV Llama 3.1 model tests.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 82396

This change restores regular CI coverage for two RocketKV model tests without changing product code or APIs; no actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

Suggested reviewers: mzweilz

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title identifies the NVBugs ID, test change, and removal of RocketKV model test waivers.
Description check ✅ Passed The description explains the issue, solution, validation results, impact, and includes the required checklist sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@lfr-0531

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #67781 [ run ] triggered by Bot. Commit: 82396cb Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #67781 [ run ] completed with state SUCCESS. Commit: 82396cb
/LLM/main/L0_MergeRequest_PR pipeline #55258 completed with status: 'SUCCESS'

CI Report

Link to invocation

@lfr-0531

Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "GB300-4_GPUs-PyTorch-Post-Merge-1"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #67812 [ run ] triggered by Bot. Commit: 82396cb Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #67812 [ run ] completed with state FAILURE. Commit: 82396cb
/LLM/main/L0_MergeRequest_PR pipeline #55280 (Partly Tested) completed with status: 'UNSTABLE'

CI Report

⚠️ Multi-GPU Label Required:
Multi-GPU tests require the ci: full pre-merge approved label on this PR. Ask a member of NVIDIA/trt-llm-ci-approvers to add the label, then re-trigger CI with the same bot command (no rebase needed).

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@lfr-0531

Copy link
Copy Markdown
Collaborator Author

I reran these tests on GB300 multiple times, and I cannot reproduce the failure.

@lfr-0531
lfr-0531 requested a review from ZhanruiSunCh August 21, 2026 01:06
@lfr-0531

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #68047 [ run ] triggered by Bot. Commit: 82396cb Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #68047 [ run ] completed with state SUCCESS. Commit: 82396cb
/LLM/main/L0_MergeRequest_PR pipeline #55501 completed with status: 'SUCCESS'

CI Report

Link to invocation

@ZhanruiSunCh ZhanruiSunCh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for infra part. Verified both unwaived test_model parametrizations (TRTLLM and VANILLA) passed in build #55258.

@lfr-0531
lfr-0531 merged commit d556198 into NVIDIA:main Aug 21, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants