Skip to content

[https://nvbugs/6633929][fix] Repoint all three links to the live versioned page and remove the now-unneeded… - #18016

Open
trtllm-agent wants to merge 2 commits into
NVIDIA:mainfrom
tensorrt-cicd:repair-bot-bug6633929
Open

[https://nvbugs/6633929][fix] Repoint all three links to the live versioned page and remove the now-unneeded…#18016
trtllm-agent wants to merge 2 commits into
NVIDIA:mainfrom
tensorrt-cicd:repair-bot-bug6633929

Conversation

@trtllm-agent

@trtllm-agent trtllm-agent commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Root cause: XGrammar moved its docs from flat /docs/<page> to versioned /docs/latest/<page> and renamed structural_tag_api.html to structural_tag.html, so the three links in guided-decoding.md return a hard HTTP 404.
  • Fix: Repoint all three links to the live versioned page and remove the now-unneeded waives.txt entry for nvbugs/6633929.
  • Original test: pytest tests/integration/defs/test_doc.py::test_url_validity -v
  • Automated fix generated by repair-bot

Test plan

  • Verify fix on the same GPU type as the original failure
  • Check for regressions in related tests

Links

Dev Engineer Review

  • Updated three XGrammar links in guided-decoding.md to versioned /docs/latest/ paths.
  • Updated the renamed page from structural_tag_api.html to structural_tag.html.
  • Removed the obsolete nvbugs/6633929 waiver.
  • Changes are limited in scope and address the 404 failures from test_doc.py::test_url_validity.

QA Engineer Review

  • Modified tests/integration/test_lists/waives.txt.
  • Removed the skipped test_doc.py::test_url_validity entry.
  • No test code changed.
  • No test-db/ or qa/ files were modified.
  • Verdict: needs follow-up because CBTS coverage data is unavailable.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e4da90a9-ac48-4ec9-bbb7-84cbe8123fae

📥 Commits

Reviewing files that changed from the base of the PR and between b5875ec and 59f5c17.

📒 Files selected for processing (2)
  • docs/source/features/guided-decoding.md
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt
🚧 Files skipped from review as they are similar to previous changes (1)
  • docs/source/features/guided-decoding.md

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The PR updates three XGrammar structural-tag documentation links and removes the related test_doc.py::test_url_validity waiver.

Changes

Documentation link and URL validation update

Layer / File(s) Summary
Update links and URL validation
docs/source/features/guided-decoding.md, tests/integration/test_lists/waives.txt
The documentation uses current structural-tag URLs. The obsolete URL validity test waiver and NVBUG reference are removed.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 59f5c

This PR only updates three documentation links and removes the waiver for the fixed URL check; no actionable merge-blocking risk remains.

Suggested reviewers: laikhtewari, nv-guomingz

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the fix: it repoints three documentation links and removes the obsolete waiver. It includes the required NVBugs ID and fix type.
Description check ✅ Passed The description explains the root cause, the solution, the affected test, and the test plan. It does not reproduce the template headings or checklist, but it provides the required change and validatio…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the root cause, the solution, the affected test, and the test plan. It does not reproduce the template headings or checklist, but it provides the required change and validation context.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@brnguyen2 brnguyen2 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving — the comments below are optional touch-ups, not blockers.

Couldn't verify the new URLs from this environment (outbound HTTP is blocked here), so the 200-vs-404 check rests on CI's test_doc.py::test_url_validity run — worth confirming that stage actually passed before merging, since the waiver removal makes the doc test gating again.


TensorRT LLM supports two grammar backends:
* [XGrammar](https://github.com/mlc-ai/xgrammar/blob/v0.1.21/python/xgrammar/matcher.py#L341-L350): Supports JSON schema, regular expression, EBNF and [structural tag](https://xgrammar.mlc.ai/docs/structural_tag/structural_tag_api.html).
* [XGrammar](https://github.com/mlc-ai/xgrammar/blob/v0.1.21/python/xgrammar/matcher.py#L341-L350): Supports JSON schema, regular expression, EBNF and [structural tag](https://xgrammar.mlc.ai/docs/latest/structural_tag/structural_tag.html).

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The structural-tag link now targets /docs/latest/, which will silently drift (or 404 again) whenever XGrammar reorganizes docs — this is the second such breakage. The adjacent source link on this same line still pins v0.1.21 while requirements.txt pins xgrammar==0.1.32. Consider pointing both at the pinned version (a versioned docs path if XGrammar publishes one) so the docs match the version actually shipped.

@trtllm-agent
trtllm-agent force-pushed the repair-bot-bug6633929 branch from 6c275ef to 0b122fa Compare August 21, 2026 21:21
XGrammar restructured its docs site: flat /docs/<page> paths moved under
/docs/latest/<page>, and structural_tag_api.html became structural_tag.html.
The old URL now 404s, failing test_doc.py::test_url_validity.

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
@trtllm-agent
trtllm-agent force-pushed the repair-bot-bug6633929 branch from 0b122fa to 59f5c17 Compare August 26, 2026 05:43
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants