[None][test] Add sparse MQA/GQA coverage and support documentation - #18106
Draft
lfr-0531 wants to merge 3 commits into
Draft
[None][test] Add sparse MQA/GQA coverage and support documentation#18106lfr-0531 wants to merge 3 commits into
lfr-0531 wants to merge 3 commits into
Conversation
Document sparse attention algorithms and the internal sparse MQA/GQA kernel support boundaries. Expand unit tests across supported dtypes, head dimensions, and query-to-KV head group limits. Signed-off-by: Fanrong Li <23290157+lfr-0531@users.noreply.github.com>
Separate kernel-specific MQA/GQA regression tests from generic sparse attention framework tests. Cover linear draft decoding, additional head-group sizes, FP8 KV cache and output, and document the verified support matrix. Signed-off-by: Fanrong Li <23290157+lfr-0531@users.noreply.github.com>
Add algorithm-neutral page-sparse MHA regression coverage and document the runtime-verified support matrix. Colocate paged-MQA and FP4 indexer tests with the DSA implementation, deduplicate the FP4 indexer suite, and keep RocketKV tests focused on algorithm-specific behavior. Signed-off-by: Fanrong Li <23290157+lfr-0531@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai summary
Description
Sparse MQA/GQA kernel support was introduced in #12470, and the sparse attention framework was subsequently unified in #12733. The internal token-sparse MQA/GQA path still lacked an explicit regression support matrix, while the sparse attention feature documentation did not distinguish this kernel capability from public sparse attention algorithms.
This PR:
This is a test and documentation change only. It does not modify runtime behavior, public APIs, kernels, or performance. The PR is intentionally kept together because the tests are both regression coverage and the executable reference for the documented internal kernel contract.
Related PRs: #12470, #12733.
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment /bot help.