Skip to content

[https://nvbugs/6561777][fix] Unwaive bug 6561775 since the fix from 6541343 is merged - #18110

Merged
EmmaQiaoCh merged 1 commit into
NVIDIA:mainfrom
EmmaQiaoCh:emma/unwaive_bug_6561775
Aug 24, 2026
Merged

[https://nvbugs/6561777][fix] Unwaive bug 6561775 since the fix from 6541343 is merged#18110
EmmaQiaoCh merged 1 commit into
NVIDIA:mainfrom
EmmaQiaoCh:emma/unwaive_bug_6561775

Conversation

@EmmaQiaoCh

@EmmaQiaoCh EmmaQiaoCh commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Dev Engineer Review

  • Removed the skip waiver for accuracy/test_llm_api_pytorch.py::TestDeepSeekR1::test_fp8_blockscale[throughput].
  • The change matches the merged fix for bug 6541343 and the unwaiver objective for bug 6561775.
  • The waiver file change has valid scope and format.
  • No API, performance, or error-handling changes were introduced.

QA Engineer Review

  • No test-db/ or qa/ files were modified.
  • Removed one entry from tests/integration/test_lists/waives.txt.
  • CBTS coverage data is unavailable.

Verdict: needs follow-up

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: EmmaQiaoCh <qqiao@nvidia.com>
@EmmaQiaoCh

Copy link
Copy Markdown
Collaborator Author

/bot run

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c86cdf8c-ce72-4017-bee1-29db996d1a40

📥 Commits

Reviewing files that changed from the base of the PR and between 2d974a7 and 8c6047e.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


Walkthrough

The integration test waiver list no longer skips TestDeepSeekR1::test_fp8_blockscale[throughput].

Changes

Test waiver update

Layer / File(s) Summary
Remove DeepSeek R1 waiver
tests/integration/test_lists/waives.txt
Removed the skip entry for the DeepSeek R1 FP8 blockscale throughput test.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 8c604

This is a narrowly scoped test-list cleanup, and no actionable merge-blocking risk remains beyond normal checks and review.

Possibly related PRs

Suggested reviewers: dongxuy04

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description contains only the template and checklist; it does not explain the issue, solution, or relevant test coverage. Add a brief issue and solution summary, and list the relevant validation or test coverage for removing the waiver.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the fix type and the main change: removing the waiver for bug 6561775 after the related fix merged.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #68656 [ run ] triggered by Bot. Commit: 8c6047e Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #68656 [ run ] completed with state FAILURE. Commit: 8c6047e
/LLM/main/L0_MergeRequest_PR pipeline #56062 completed with status: 'UNSTABLE'

CI Report

⚠️ Multi-GPU Label Required:
Multi-GPU tests require the ci: full pre-merge approved label on this PR. Ask a member of NVIDIA/trt-llm-ci-approvers to add the label, then re-trigger CI with the same bot command (no rebase needed).

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@EmmaQiaoCh

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #68704 [ run ] triggered by Bot. Commit: 8c6047e Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #68704 [ run ] completed with state SUCCESS. Commit: 8c6047e
/LLM/main/L0_MergeRequest_PR pipeline #56104 completed with status: 'SUCCESS'

CI Report

Link to invocation

@EmmaQiaoCh
EmmaQiaoCh merged commit 5b7a888 into NVIDIA:main Aug 24, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants