Skip to content

[https://nvbugs/6581049][ci] Unwaive test - #18394

Merged
2ez4bz merged 1 commit into
NVIDIA:mainfrom
2ez4bz:dev-nano-cg
Aug 29, 2026
Merged

[https://nvbugs/6581049][ci] Unwaive test#18394
2ez4bz merged 1 commit into
NVIDIA:mainfrom
2ez4bz:dev-nano-cg

Conversation

@2ez4bz

@2ez4bz 2ez4bz commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Dev Engineer Review

  • Removed the waiver for accuracy/test_llm_api_pytorch_multimodal.py::TestNanoV3Omni::test_auto_dtype[fp8_mmmu_encoder_cuda_graph].
  • The change has valid waives.txt format and references NVBug 6581049.
  • No code, API, or performance changes were made.
  • No duplicate or unintended waiver changes were identified.

QA Engineer Review

  • Modified tests/integration/test_lists/waives.txt.
  • Removed one waived test entry.
  • CBTS coverage data is unavailable.
  • Verdict: needs follow-up.

Description

#17925 and #17949 were merged around the same time.

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: William Zhang <133824995+2ez4bz@users.noreply.github.com>
@2ez4bz

2ez4bz commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e8cacc28-5cc5-4b94-88da-184bd3a55916

📥 Commits

Reviewing files that changed from the base of the PR and between ef3124d and cf20608.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The change removes the skip waiver for the NanoV3Omni FP8 MMMU encoder CUDA-graph auto-dtype integration test.

Changes

Test waiver update

Layer / File(s) Summary
Remove NanoV3Omni test waiver
tests/integration/test_lists/waives.txt
The skip entry for accuracy/test_llm_api_pytorch_multimodal.py::TestNanoV3Omni::test_auto_dtype[fp8_mmmu_encoder_cuda_graph] was removed.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to cf206

This localized test-list change introduces no actionable merge-blocking risk and is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description gives limited merge-order context, but it does not explain the solution or provide test coverage. The required Test Coverage section remains empty. Add a concise explanation that the waiver for the test tracked by NVBug 6581049 was removed, and list the relevant test or CI validation used to confirm the change.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the NVBug, CI context, and primary change: removing a test waiver.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #70088 [ run ] triggered by Bot. Commit: cf20608 Link to invocation

@2ez4bz
2ez4bz enabled auto-merge (squash) August 28, 2026 23:56
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #70088 [ run ] completed with state SUCCESS. Commit: cf20608
/LLM/main/L0_MergeRequest_PR pipeline #57355 completed with status: 'SUCCESS'

CI Report

Link to invocation

@2ez4bz
2ez4bz merged commit 2e5dbe0 into NVIDIA:main Aug 29, 2026
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants