Add DriveOS sample build instructions to the README - #4844
Open
poweiw wants to merge 1 commit into
Open
Conversation
Signed-off-by: Po-Wei Wang (Vincent) <poweiw@nvidia.com>
poweiw
force-pushed
the
dev-poweiw-dos-sample-readme
branch
from
September 1, 2026 21:47
456ed9b to
cf7469f
Compare
sylvesterkaczmarek
left a comment
sylvesterkaczmarek
left a comment
There was a problem hiding this comment.
The new DriveOS examples jump directly to cd $TRT_OSSPATH and -DTRT_LIB_DIR=$TRT_LIBPATH, but this section never establishes those variables.
Could we either define them explicitly after cloning the repository, or state that the DriveOS NSR container is guaranteed to provide them and what they point to? Otherwise someone following this section in a fresh DriveOS container can fail before reaching CMake, with no indication of what values are expected.
zeroepoch
reviewed
Sep 4, 2026
| make -j$(nproc) | ||
| ``` | ||
|
|
||
| > NOTE: Set `QNX_BASE` to your QNX toolchain installation path. |
Contributor
There was a problem hiding this comment.
Should these notes be before the commands?
zeroepoch
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.