Skip to content

Update PSLP to v0.0.12 - #1943

Open
hlinsen wants to merge 1 commit into
NVIDIA:mainfrom
hlinsen:upgrade-papilo-v0.12
Open

hlinsen wants to merge 1 commit into
NVIDIA:mainfrom
hlinsen:upgrade-papilo-v0.12

Conversation

@hlinsen

@hlinsen hlinsen commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Hugo Linsenmaier <hlinsenmaier@gmail.com>
@hlinsen
hlinsen requested review from a team as code owners September 18, 2026 18:35
@hlinsen
hlinsen requested a review from tmckayus September 18, 2026 18:35
@copy-pr-bot

copy-pr-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@hlinsen hlinsen added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Sep 18, 2026
@hlinsen

hlinsen commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 7e8ab67

@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 56d6aecf-0d1e-4cf3-8dc0-f5e7c6443752

📥 Commits

Reviewing files that changed from the base of the PR and between 1d591b2 and 7e8ab67.

📒 Files selected for processing (1)
  • cpp/CMakeLists.txt

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The CMake configuration updates the PSLP FetchContent reference from a pinned commit to the released v0.0.12 tag.

Changes

PSLP dependency update

Layer / File(s) Summary
Update PSLP FetchContent reference
cpp/CMakeLists.txt
The PSLP dependency now tracks release tag v0.0.12 instead of the previous commit.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 7e8ab

No concrete build or runtime risk is shown for this dependency pin, so the change is mergeable with normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided, so the description does not communicate any meaningful information about the dependency update. Add a brief description stating that the PSLP dependency changed from commit 12d37dd9ab5ee848b3ec5da17f4cf8e805d58cd6 to release v0.0.12.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: updating the PSLP dependency to v0.0.12.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@rg20 rg20 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets make sure there is no regression in performance.

@github-actions

Copy link
Copy Markdown

CI Test Summary

✅ All 32 test job(s) passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants