Skip to content

Enable all NVCC warnings as errors - #1948

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
mlubin:ml/nvcc-all-warnings
Sep 21, 2026
Merged

rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
mlubin:ml/nvcc-all-warnings

Conversation

@mlubin

@mlubin mlubin commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Switch to --Werror=all-warnings and fix corresponding errors in preparation for adding more checks in #1944. Split out for easier review of CUDA changes.

Signed-off-by: Miles Lubin <mlubin@nvidia.com>
@mlubin
mlubin requested review from a team as code owners September 19, 2026 01:39
@copy-pr-bot

copy-pr-bot Bot commented Sep 19, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@mlubin mlubin added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Sep 19, 2026
@mlubin
mlubin requested review from ramakrishnap-nv and removed request for chris-maes and tmckayus September 19, 2026 01:40
@mlubin

mlubin commented Sep 19, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 502ae39

@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: NVIDIA/cuopt/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 350efa10-0091-4c49-873e-7059bc22d3e3

📥 Commits

Reviewing files that changed from the base of the PR and between 9acf7c8 and 502ae39.

📒 Files selected for processing (3)
  • cpp/CMakeLists.txt
  • cpp/src/mip_heuristics/feasibility_jump/load_balancing.cuh
  • cpp/tests/CMakeLists.txt

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The PR updates CUDA warning flags, selects architecture-specific kernel launch bounds, and changes DejaVu include-directory handling for test targets.

Changes

CUDA configuration updates

Layer / File(s) Summary
CUDA compiler warning flags
cpp/CMakeLists.txt
CUDA compilation enables --Werror=all-warnings, suppresses diagnostic 177, and retains the existing CUDA and host warning options.
Architecture-specific launch bounds
cpp/src/mip_heuristics/feasibility_jump/load_balancing.cuh
load_balancing_mtm_compute_scores selects 8, 12, or 16 minimum blocks per SM based on the CUDA architecture. The SPDX year range now ends in 2026.
Test include configuration
cpp/tests/CMakeLists.txt
Test utilities and configured test executables add ${dejavu_SOURCE_DIR} through separate SYSTEM PRIVATE include-directory declarations.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Suggested reviewers: chris-maes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely states the main change: NVCC will treat all warnings as errors.
Description check ✅ Passed The description directly explains the warning configuration change, the resulting fixes, and the reason for splitting the CUDA changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

CI Test Summary

✅ All 32 test job(s) passed.

@mlubin

mlubin commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit c80859c into NVIDIA:main Sep 21, 2026
76 checks passed
@mlubin
mlubin deleted the ml/nvcc-all-warnings branch September 21, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants