Skip to content

Fix run mip tolerance - #1956

Merged
rapids-bot[bot] merged 8 commits into
NVIDIA:mainfrom
akifcorduk:fix_run_mip_tolerance
Sep 22, 2026
Merged

rapids-bot[bot] merged 8 commits into
NVIDIA:mainfrom
akifcorduk:fix_run_mip_tolerance

Conversation

@akifcorduk

Copy link
Copy Markdown
Contributor

Fix the tolerance checks in harness.

@akifcorduk akifcorduk added this to the 26.10 milestone Sep 21, 2026
@akifcorduk
akifcorduk requested a review from a team as a code owner September 21, 2026 13:09
@akifcorduk akifcorduk added bug Something isn't working non-breaking Introduces a non-breaking change labels Sep 21, 2026
@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: NVIDIA/cuopt/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 15aefc02-a652-452a-b3ee-e1fa40dbc374

📥 Commits

Reviewing files that changed from the base of the PR and between c80859c and 5f73e23.

📒 Files selected for processing (1)
  • benchmarks/linear_programming/cuopt/initial_problem_check.hpp

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The solution verifier removes unused scaled-bound helpers. It applies integrality_tolerance directly to variable-bound checks and integer rounding residuals. Failure messages report the configured tolerance and residual.

Changes

Solution validation

Layer / File(s) Summary
Tolerance-based solution checks
benchmarks/linear_programming/cuopt/initial_problem_check.hpp
Removes scaled_bound_limits and bound_excess. Updates verify_solution to use integrality_tolerance for bounds and integer residuals, and updates failure diagnostics.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: fixing MIP tolerance handling in the harness.
Description check ✅ Passed The description accurately states that the pull request fixes tolerance checks in the harness.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

CI Test Summary

✅ All 32 test job(s) passed.

@akifcorduk

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit ea99b17 into NVIDIA:main Sep 22, 2026
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants