Skip to content

fix(self-managed): correct worker discovery endpoint - #2016

Merged
sbaum1994 merged 1 commit into
release-deploy/stacks/self-managed/v1.0from
fix/self-managed-1.0/worker-discovery-endpoint
Sep 22, 2026
Merged

sbaum1994 merged 1 commit into
release-deploy/stacks/self-managed/v1.0from
fix/self-managed-1.0/worker-discovery-endpoint

Conversation

@along-2017

Copy link
Copy Markdown
Contributor

TL;DR

Backport #1989 to the self-managed 1.0 release. When backend routing is enabled, worker discovery now defaults to the backend-router service and its separately configurable gRPC port.

Additional Details

  • Keep the request-router service as the default when backend routing is disabled.
  • Document both defaults and cover them with render and BDD wiring tests.

For the Reviewer

For QA

  • deploy/stacks/self-managed/tests/llm-router-worker-address.sh and api-env-wiring.sh passed.
  • go test -short ./... passed in tests/bdd.

Issues

Relates to #1990

Checklist

  • I am familiar with the Contributing Guidelines.
  • I have signed off my commits for Developer Certificate of Origin (DCO) compliance.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Signed-off-by: along <along@nvidia.com>
(cherry picked from commit 104efb2)
@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: NVIDIA/nvcf/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c6eb0804-e917-4eea-a30b-01bab979f934

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@along-2017
along-2017 marked this pull request as ready for review September 22, 2026 01:56
@along-2017
along-2017 requested review from a team as code owners September 22, 2026 01:56
@github-actions

Copy link
Copy Markdown
Contributor

@sbaum1994
sbaum1994 merged commit a23f740 into release-deploy/stacks/self-managed/v1.0 Sep 22, 2026
17 checks passed
@sbaum1994
sbaum1994 deleted the fix/self-managed-1.0/worker-discovery-endpoint branch September 22, 2026 03:47
@balajinvda

Copy link
Copy Markdown
Contributor

This PR is included in version 1.0.1.

The release is available on GitHub release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants