Conversation
Signed-off-by: along <along@nvidia.com> (cherry picked from commit 104efb2)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: NVIDIA/nvcf/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Contributor
sbaum1994
approved these changes
Sep 22, 2026
sbaum1994
merged commit Sep 22, 2026
a23f740
into
release-deploy/stacks/self-managed/v1.0
17 checks passed
sbaum1994
deleted the
fix/self-managed-1.0/worker-discovery-endpoint
branch
September 22, 2026 03:47
Contributor
|
This PR is included in version 1.0.1. The release is available on GitHub release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Backport #1989 to the self-managed 1.0 release. When backend routing is enabled, worker discovery now defaults to the backend-router service and its separately configurable gRPC port.
Additional Details
For the Reviewer
For QA
deploy/stacks/self-managed/tests/llm-router-worker-address.shandapi-env-wiring.shpassed.go test -short ./...passed intests/bdd.Issues
Relates to #1990
Checklist