fix(byoo): retain collector and cAdvisor metrics - #693
Merged
Conversation
📝 WalkthroughWalkthroughThe BYOO OTEL Collector now retains all ChangesCollector metric retention
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/compute-plane-services/byoo-otel-collector/generator/doc/README.md`:
- Around line 186-198: Update both raw-counter-inputs headings in the README to
use the valid #### level under their existing ### parent headings, preserving
the surrounding counter input lists and text.
In `@src/compute-plane-services/byoo-otel-collector/generator/source-config.yaml`:
- Around line 459-472: Retain raw exporter failure counters by adding all six
raw counter names to both raw-counter-inputs lists in
src/compute-plane-services/byoo-otel-collector/generator/source-config.yaml
(459-472 and 689-702), update RAW_SELF_SCRAPE_COUNTER_METRICS in
src/compute-plane-services/byoo-otel-collector/generator/test_prometheus_config_generator.py
(37-49), and regenerate the committed outputs for
src/compute-plane-services/byoo-otel-collector/generator/doc/README.md (186-198,
318-330) plus the Kubernetes and VM templates at the specified ranges; use
collector version v0.157.0.
In
`@src/compute-plane-services/byoo-otel-collector/generator/test_prometheus_config_generator.py`:
- Around line 107-112: Update the assertions in the rendered-template test to
verify each RAW_SELF_SCRAPE_COUNTER_METRICS entry as a complete metric token
rather than a substring, so a metric suffixed with “_total” cannot satisfy the
check. Use complete regex alternatives or parse the generated keep regex while
preserving validation across every template in template_names.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 550a0c96-d640-4663-b547-26f801ee34dc
⛔ Files ignored due to path filters (4)
src/compute-plane-services/byoo-otel-collector/generator/gen/generated_src-config-k8s-container.yaml.tmplis excluded by!**/gen/**src/compute-plane-services/byoo-otel-collector/generator/gen/generated_src-config-k8s-helm.yaml.tmplis excluded by!**/gen/**src/compute-plane-services/byoo-otel-collector/generator/gen/generated_src-config-vm-container.yaml.tmplis excluded by!**/gen/**src/compute-plane-services/byoo-otel-collector/generator/gen/generated_src-config-vm-helm.yaml.tmplis excluded by!**/gen/**
📒 Files selected for processing (89)
src/compute-plane-services/byoo-otel-collector/VERSIONsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_azure_monitor.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_input1.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_input2.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_input3.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_input4.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_kratos_logs_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_kratos_thanos_prd.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_metric_subset.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_otelcollector_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_telemetry_endpoint_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_helm_azure_monitor.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_helm_input1.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_helm_input2.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_helm_input3.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_helm_input4.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_helm_kratos_logs_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_helm_kratos_thanos_prd.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_helm_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_helm_otelcollector_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_helm_telemetry_endpoint_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_azure_monitor.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_input1.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_input2.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_input3.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_input4.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_kratos_logs_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_kratos_thanos_prd.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_otelcollector_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_telemetry_endpoint_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_helm_azure_monitor.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_helm_input1.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_helm_input2.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_helm_input3.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_helm_input4.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_helm_kratos_logs_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_helm_kratos_thanos_prd.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_helm_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_helm_otelcollector_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_helm_telemetry_endpoint_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_container_azure_monitor.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_container_input1.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_container_input2.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_container_input3.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_container_input4.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_container_kratos_logs_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_container_kratos_thanos_prd.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_container_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_container_otelcollector_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_container_telemetry_endpoint_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_helm_azure_monitor.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_helm_input1.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_helm_input2.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_helm_input3.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_helm_input4.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_helm_kratos_logs_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_helm_kratos_thanos_prd.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_helm_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_helm_otelcollector_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_function_helm_telemetry_endpoint_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_container_azure_monitor.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_container_input1.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_container_input2.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_container_input3.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_container_input4.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_container_kratos_logs_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_container_kratos_thanos_prd.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_container_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_container_otelcollector_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_container_telemetry_endpoint_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_helm_azure_monitor.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_helm_input1.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_helm_input2.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_helm_input3.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_helm_input4.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_helm_kratos_logs_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_helm_kratos_thanos_prd.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_helm_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_helm_otelcollector_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/vm/config_task_helm_telemetry_endpoint_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/generator/doc/README.mdsrc/compute-plane-services/byoo-otel-collector/generator/source-config.yamlsrc/compute-plane-services/byoo-otel-collector/generator/test_prometheus_config_generator.pysrc/compute-plane-services/byoo-otel-collector/internal/otelconfig/templates/config-k8s-container.yaml.tmplsrc/compute-plane-services/byoo-otel-collector/internal/otelconfig/templates/config-k8s-helm.yaml.tmplsrc/compute-plane-services/byoo-otel-collector/internal/otelconfig/templates/config-vm-container.yaml.tmplsrc/compute-plane-services/byoo-otel-collector/internal/otelconfig/templates/config-vm-helm.yaml.tmpl
kristinapathak
changed the title
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/compute-plane-services/byoo-otel-collector/generator/test_prometheus_config_generator.py (1)
53-69: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winAssert the cAdvisor label-clearing order.
The PR contract requires the
containerlabel to be cleared before the existing label allowlist. This test only checks thatCADVISOR_POD_SELECTORappears in the cAdvisor block. It can pass while the label remains or while clearing occurs after the allowlist. Assert the rendered label-clearing rule and its position relative to the allowlist.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/compute-plane-services/byoo-otel-collector/generator/test_prometheus_config_generator.py` around lines 53 - 69, Update test_k8s_container_cadvisor_keeps_pod_sandbox_metrics to assert the rendered cAdvisor configuration clears the container label and that this rule appears before the existing label allowlist, using the relevant rendered rule text or symbols already defined in the test. Keep the existing CADVISOR_POD_SELECTOR assertion.
🧹 Nitpick comments (1)
src/compute-plane-services/byoo-otel-collector/generator/test_markdown_helper.py (1)
10-31: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winCover the generic-category branch.
The implementation intentionally omits a category heading for
catagory: generic, but this test covers onlyCPU. Add a generic category and assert that its metrics render without a####heading.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/compute-plane-services/byoo-otel-collector/generator/test_markdown_helper.py` around lines 10 - 31, Add coverage to test_category_heading_is_one_level_below_job_heading for a metric_allow_list entry with catagory set to generic, and assert that the generic category’s metrics are rendered without a #### category heading while preserving the existing CPU heading assertions.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In
`@src/compute-plane-services/byoo-otel-collector/generator/test_prometheus_config_generator.py`:
- Around line 53-69: Update
test_k8s_container_cadvisor_keeps_pod_sandbox_metrics to assert the rendered
cAdvisor configuration clears the container label and that this rule appears
before the existing label allowlist, using the relevant rendered rule text or
symbols already defined in the test. Keep the existing CADVISOR_POD_SELECTOR
assertion.
---
Nitpick comments:
In
`@src/compute-plane-services/byoo-otel-collector/generator/test_markdown_helper.py`:
- Around line 10-31: Add coverage to
test_category_heading_is_one_level_below_job_heading for a metric_allow_list
entry with catagory set to generic, and assert that the generic category’s
metrics are rendered without a #### category heading while preserving the
existing CPU heading assertions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 2a29dec9-e89a-4282-bed3-f39900695d41
⛔ Files ignored due to path filters (1)
src/compute-plane-services/byoo-otel-collector/generator/gen/generated_src-config-k8s-container.yaml.tmplis excluded by!**/gen/**
📒 Files selected for processing (34)
src/compute-plane-services/byoo-otel-collector/VERSIONsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_azure_monitor.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_input1.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_input2.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_input3.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_input4.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_kratos_logs_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_kratos_thanos_prd.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_metric_subset.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_otelcollector_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_telemetry_endpoint_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_azure_monitor.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_input1.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_input2.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_input3.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_input4.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_kratos_logs_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_kratos_thanos_prd.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_otelcollector_stg.yamlsrc/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_telemetry_endpoint_kratos_thanos_stg.yamlsrc/compute-plane-services/byoo-otel-collector/generator/doc/README.mdsrc/compute-plane-services/byoo-otel-collector/generator/markdown_helper.pysrc/compute-plane-services/byoo-otel-collector/generator/test_markdown_helper.pysrc/compute-plane-services/byoo-otel-collector/generator/test_prometheus_config_generator.pysrc/compute-plane-services/byoo-otel-collector/internal/otelconfig/source_templates/src-config-k8s-container.yaml.tmplsrc/compute-plane-services/byoo-otel-collector/internal/otelconfig/templates/config-k8s-container.yaml.tmplsrc/libraries/go/lib/validator/otelconfig/golden/metrics_gfn_function_container.jsonsrc/libraries/go/lib/validator/otelconfig/golden/metrics_gfn_function_helm.jsonsrc/libraries/go/lib/validator/otelconfig/golden/metrics_non-gfn_function_container.jsonsrc/libraries/go/lib/validator/otelconfig/golden/metrics_non-gfn_function_helm.jsontools/byoo/otelconfig-validate/golden.gotools/byoo/otelconfig-validate/golden_test.go
💤 Files with no reviewable changes (23)
- src/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_kratos_thanos_stg.yaml
- src/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_telemetry_endpoint_kratos_thanos_stg.yaml
- src/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_input4.yaml
- src/compute-plane-services/byoo-otel-collector/internal/otelconfig/templates/config-k8s-container.yaml.tmpl
- src/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_otelcollector_stg.yaml
- src/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_input1.yaml
- src/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_telemetry_endpoint_kratos_thanos_stg.yaml
- src/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_otelcollector_stg.yaml
- src/compute-plane-services/byoo-otel-collector/internal/otelconfig/source_templates/src-config-k8s-container.yaml.tmpl
- src/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_kratos_logs_stg.yaml
- src/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_input1.yaml
- src/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_kratos_thanos_stg.yaml
- src/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_input3.yaml
- src/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_metric_subset.yaml
- src/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_input4.yaml
- src/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_azure_monitor.yaml
- src/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_input3.yaml
- src/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_input2.yaml
- src/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_input2.yaml
- src/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_kratos_thanos_prd.yaml
- src/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_task_container_kratos_thanos_prd.yaml
- src/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_kratos_logs_stg.yaml
- src/compute-plane-services/byoo-otel-collector/examples/otelconfigs/k8s/config_function_container_azure_monitor.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
- src/compute-plane-services/byoo-otel-collector/VERSION
Contributor
|
Quick note on the description — it says the container value is cleared before labelkeep, but looking at the code I think the intent is actually to keep it. The existing labelkeep in the cAdvisor block already includes container in its regex, and the golden file updates confirm "container": "POD" shows up in the exported metrics as expected, should we update the decsription to match ? |
Contributor
Author
|
thanks for pointing that out - I'll update the description. Originally the "container": "POD" was being removed, but I decided that wasn't the direction we wanted to take. |
kristinapathak
enabled auto-merge
August 6, 2026 05:31
apartha-nv
approved these changes
Aug 6, 2026
apartha-nv
left a comment
apartha-nv
left a comment
Contributor
There was a problem hiding this comment.
Left couple of minor comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The collector self-scrape emitted valid internal metrics whose names did not
match the generated exact allowlist. The Kubernetes cAdvisor selector also
excluded pod-sandbox series, which provide pod network metrics and additional
CPU and memory variants.
Issues
Closes #692
What changed
otelcol_.*.container="POD"sandbox series for Kubernetescontainer workloads.
conditional
kube_configmap_createdmetric as optional.Customer Release Notes
Restores collector self-observability and cAdvisor pod-network metrics for
BYOO telemetry.
Plan Summary
Not applicable.
Usage
Not applicable.
Testing
make update-config-templatemake update-examplesgo test ./internal/otelconfiggo test .fromtools/byoo/otelconfig-validateNotes
The upstream cAdvisor POD label is preserved for downstream consumers.
References
None.
Related Pull Requests
None.
Dependencies
None.