feat(nvca): configure transport TLS mount path - #708
Closed
mikeyrcamp wants to merge 1 commit into
Closed
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
kristinapathak
approved these changes
Aug 6, 2026
mikeyrcamp
enabled auto-merge (squash)
August 6, 2026 19:46
This was referenced Aug 6, 2026
Contributor
Author
|
Superseded by #718, which consolidates the transport-TLS work on current main. |
auto-merge was automatically disabled
August 6, 2026 21:30
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer Summary
Managed NVCA deployments can isolate router transport trust from the cluster-wide certificate path, avoiding admission-time mount collisions while retaining the existing default behavior.
TL;DR
Adds
operatorConfig.workload.transportTLS.installedBundleMountPath. When omitted, NVCA continues using/etc/ssl/certs; dev2 uses/nvcf/transport-tlsfor the router CA.Additional Details
nvcf-trust-merged-certsat the configured path and derivesSTARGATE_TLS_CERT_PATHas<path>/ca-certificates.crt./merged-certs/ca-certificates.crtand general/proxy trust at/etc/ssl/certs.For the Reviewer
This is the v3.1 source PR. PR #672 contains the corresponding main-line change. The only backport resolution adjusted Bazel dependency labels to the release branch convention; behavior is unchanged.
For QA
Passed:
go test ./internal/transporttls ./pkg/operator/reconcile ./pkg/nvca ./internal/miniservice -count=1./scripts/lint_helm.shoperatorConfig.workload.transportTLS.installedBundleMountPath=/nvcf/transport-tls./etc/ssl/certs, Pylon setSTARGATE_TLS_CERT_PATH=/nvcf/transport-tls/ca-certificates.crt, and the reverse tunnel connected withoutUnknownIssuer.For the dev test, the byocdev image was pre-pulled temporarily onto both GPU nodes because API-issued workload credentials currently authorize only the staging registry. The temporary DaemonSet and credential were removed. Cold-node validation requires staging publication or an API-issued byocdev pull credential.
Tickets