Skip to content

nvidia: use nv_vmalloc when pt_size >= PMD_SIZE to avoid direct compaction under lock #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hyuuko1 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −3
Open

nvidia: use nv_vmalloc when pt_size >= PMD_SIZE to avoid direct compaction under lock #1383

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions kernel-open/nvidia/nv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,8 +433,12 @@ nv_alloc_t *nvos_create_alloc(
return NULL;
}

/* kvzalloc() rejects sizes > INT_MAX; use vmalloc() for oversized tables. */
if (pt_size > (NvU64)INT_MAX)
/*
* Use nv_vmalloc() for pt_size >= PMD_SIZE to avoid huge page allocation
* and direct compaction while holding locks. This also covers oversized
* tables (> INT_MAX), which kvzalloc() rejects.
*/
if (pt_size >= (NvU64)PMD_SIZE)
at->page_table = nv_vmalloc(pt_size, NV_GFP_KERNEL | __GFP_ZERO);
else
at->page_table = kvzalloc(pt_size, NV_GFP_KERNEL);
Expand Down Expand Up @@ -468,7 +472,7 @@ int nvos_free_alloc(

pt_size = (NvU64)at->num_pages * sizeof(nvidia_pte_t);

if (pt_size > (NvU64)INT_MAX)
if (pt_size >= (NvU64)PMD_SIZE)
nv_vfree(at->page_table, pt_size);
else
kvfree(at->page_table);
Expand Down