fix: add parallel_scheduler also to export targets in CMake#2133
Open
miwechner wants to merge 1 commit into
Open
fix: add parallel_scheduler also to export targets in CMake#2133miwechner wants to merge 1 commit into
miwechner wants to merge 1 commit into
Conversation
Collaborator
|
/ok to test 624e74c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the generated
stdexec-config.cmakemade the CMake targetSTDEXEC::stdexecIMPORTED_GLOBAL, but notSTDEXEC::parallel_scheduler.This would cause an error in CMake if you were to use
find_package(stdexec)in many CMake sub-projects, because some but not all targets of the package are already defined.Solution is rather simple I think: make sure parallel_scheduler is also in the variable rapids_global_targets, which we can do by adding it to
stdexec_export_targets.