Skip to content

script: Use correct buffer length variable#641

Merged
rsmarples merged 3 commits into
NetworkConfiguration:masterfrom
craciunoiuc:craciunoiuc/incorrect-size-used
Jun 17, 2026
Merged

script: Use correct buffer length variable#641
rsmarples merged 3 commits into
NetworkConfiguration:masterfrom
craciunoiuc:craciunoiuc/incorrect-size-used

Conversation

@craciunoiuc

Copy link
Copy Markdown
Contributor

Final call to the control queue used the wrong 'buflen' variable. Change so the function stays consistent.

craciunoiuc and others added 3 commits June 17, 2026 11:52
Final call to the control queue used the wrong 'buflen'
variable. Change so the function stays consistent.

Signed-off-by: Cezar Craciunoiu <cezar@unikraft.io>
@rsmarples

Copy link
Copy Markdown
Member

@coderabbitai review

@rsmarples rsmarples merged commit ddc57fe into NetworkConfiguration:master Jun 17, 2026
4 checks passed
@rsmarples

Copy link
Copy Markdown
Member

Thanks!

rsmarples pushed a commit that referenced this pull request Jun 17, 2026
Final call to the control queue used the wrong 'buflen'
variable. Change so the function stays consistent.

Signed-off-by: Cezar Craciunoiu <cezar@unikraft.io>
@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@rsmarples, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 14 minutes and 14 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3c20cdb2-9aa5-47a2-ac30-d9297912dabd

📥 Commits

Reviewing files that changed from the base of the PR and between 2d2d28e and 81ac6c8.

📒 Files selected for processing (1)
  • src/script.c

Walkthrough

In script_runreason, the control_queue call that notifies registered control listeners is updated to pass the locally computed buflen (cast to size_t) as the payload length, replacing the previously used ctx->script_buflen.

Changes

Fix payload length in control_queue call

Layer / File(s) Summary
Use local buflen in control_queue call
src/script.c
control_queue in script_runreason now uses the locally computed buflen (cast to size_t) instead of ctx->script_buflen as the payload length argument.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants