chore(desktop): upgrade bundled Node to 24.20.0 LTS - #679
Open
pascalandr wants to merge 9 commits into
Open
pascalandr wants to merge 9 commits into
pascalandr wants to merge 9 commits into
Conversation
Use one exact .node-version pin for the standalone server runtime shipped by both desktop hosts and all Node CI setup steps. Preserve official archive checksum verification and binary-only packaging; Electron's internal runtime, the system Node installation, and OpenCode remain unchanged. Require macOS 13.5 in both bundle manifests to match the Node 24 binaries and document the compatibility change. Strengthen packaged-resource smoke checks to reject stale Node versions and import the ESM-only V2 client from the packaged dependency tree. Add regression tests for the shared runtime/CI pin and macOS host parity. On Windows with Node 24.20.0 and npm 11.19.0: clean npm ci, all typechecks, 391 server tests (2 skipped), 192 Electron tests, and 6 packaging tests pass. Rebuilt Tauri server/UI resources pass packaged startup/import/version smoke checks; an old Node 22 package is rejected. Native GUI and non-Windows validation remain for CI/release review.
|
PR builds are available as GitHub Actions artifacts: https://github.com/NeuralNomadsAI/CodeNomad/actions/runs/34120189285 Artifacts expire in 7 days.
|
|
PR builds are available as GitHub Actions artifacts: https://github.com/NeuralNomadsAI/CodeNomad/actions/runs/34150205504 Artifacts expire in 7 days.
|
|
PR builds are available as GitHub Actions artifacts: https://github.com/NeuralNomadsAI/CodeNomad/actions/runs/34160953653 Artifacts expire in 7 days.
|
Integrate dev@ea37f97b after the global-session, nested-scroll, and selective-pruning fixes while preserving the bundled Node 24 runtime update. The merge is conflict-free and keeps the PR history intact for exact-head CI validation.
The latest dev merge added a native pruning job with a literal Node 22 setup step. Point that job at the checked-out .node-version so the bundled Node 24 branch keeps every workflow on one reviewed runtime source. This also satisfies the branch invariant that rejects setup-node steps which bypass the repository pin. Validated with both desktop packaging and managed-runtime test suites.
Node 24 exposed GitHub Windows runners where Get-CimInstance exceeded both bounded lookup attempts, leaving the Node election participant without an owner identity and making the cross-host Tauri tests report two secondaries. Use Get-Process.StartTime in both Electron's synchronous/asynchronous lookups and the Rust host so they still compare the same UTC tick value without paying the WMI startup cost. Validated with the Electron typecheck, 42 focused process/election tests, all 160 Tauri tests in CI order, and the 7 bundled-runtime and packaging invariants.
|
PR builds are available as GitHub Actions artifacts: https://github.com/NeuralNomadsAI/CodeNomad/actions/runs/34490346837 Artifacts expire in 7 days.
|
Merge dev aa51cbb and update the packaged-resource smoke check to import @opencode/client instead of the removed @opencode-ai/client package. Preserve the pinned Node 24.20.0 LTS runtime and dev's 2.0.4 client/plugin lock. Validation: packaged Windows resources report Node v24.20.0, launch the server version probe, import all required dependencies and resolve loading assets. Server 500 passed/2 skipped; UI stores 441 passed; Electron native 194 passed/4 skipped; server/UI/Electron typechecks and packaged server/UI build passed. Other platform packaging remains for CI.
Contributor
Author
Refresh against dev aa51cbbPublished head: merge(dev): verify Node 24 packaging with the official OpenCode client Merge dev aa51cbb and update the packaged-resource smoke check to import Validation: packaged Windows resources report Node v24.20.0, launch the server Validation above is local execution evidence. CI on this published head and the explicitly untested interactive/platform scenarios remain separate. No PR was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.node-versionpin consumed by the runtime preparation script and all Node CI setup steps, replacing the previous Node 20/22 build/test split. Official archive SHA-256 verification and executable-only packaging are preserved.Scope and compatibility
This updates the Node process running the CodeNomad backend. It does not upgrade Electron 39 or its internal Node/Chromium, WebView2, the user's Node installation, or the independently managed OpenCode daemon. No application dependencies or lockfile versions are changed.
Node 24's official macOS binaries require 13.5 rather than Node 22's 11.0. Windows x64/ARM64 and Linux glibc x64/ARM64 keep their existing Node platform floors. No additional platform or musl support is introduced.
The Windows x64 Node executable increases from approximately 83.04 MiB to 89.06 MiB uncompressed. Final installer/archive size changes have not been measured. This is a runtime maintenance update, not the deferred packaging-size optimization.
Validation
Performed in an isolated worktree on Windows with the official, checksum-verified Node 24.20.0 / npm 11.19.0 distribution:
npm ci; lockfile unchanged.npm run bundle:server --workspace @codenomad/tauri-app: rebuild UI/server resources, stage production dependencies, download/check/extract Node 24, and run packaged startup/import/loading-asset checks.git diff --check.The preliminary compatibility study also loaded all 14 direct server dependencies and the packaged
msgpackr-extractN-API binary under Node 24, with a successful serialization roundtrip.Remaining release gates / existing warnings
npm cistill reports the existing 49 dependency advisories; this PR does not run an unrelated dependency upgrade. npm 11.19 also warns about existing install scripts awaitingallowScriptscoverage.actionlintreports only the pre-existing constant-false condition inbuild-and-upload.yml(now line 816).The touched
build-and-upload.ymlremains approximately 913 lines; no unrelated workflow refactor is included.