Route gameWillTerminate, deviceWillSleep, deviceWillLock, and deviceDidUnlock to scene methods - #96
Open
ericlewis wants to merge 1 commit into
Open
Conversation
…idUnlock to scene methods. (upstream issue NobleRobot#55) Mirrors the existing gameWillPause()/gameWillResume() pattern: each SDK lifecycle callback calls the same-named method on the current scene, with documented no-op defaults in NobleScene and matching debug bonk checks in Noble.Bonk for games that define these SDK callbacks manually. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
✅ Deploy Preview for cheery-choux-736619 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55.
Routes
playdate.gameWillTerminate(),playdate.deviceWillSleep(),playdate.deviceWillLock(), andplaydate.deviceDidUnlock()to same-named methods on the current scene, mirroring the existinggameWillPause()/gameWillResume()pattern:Noble.luadefines the four SDK callbacks and forwards toNoble.currentScene():<method>().NobleScenegains documented no-op defaults, including a note about the OS's ~10-second watchdog forgameWillTerminate().Noble.Bonkgains matching debug checks (same as the existinggameWillPause/gameWillResumechecks) so games that define these SDK callbacks manually get a warning instead of silently overriding the engine's routing.Source LDoc comments are in place; I left the generated
.docsHTML out of this PR to avoid churn — it'll regenerate on the next docs build.🤖 Generated with Claude Code