feat(claude): nudge to update plugin version if a newer one exists#734
Open
OisinKyne wants to merge 1 commit into
Open
feat(claude): nudge to update plugin version if a newer one exists#734OisinKyne wants to merge 1 commit into
OisinKyne wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(claude): nudge to update the Obol skills plugin when a newer version is released
obol stack upalready tips Claude Code users toward installing the Obol skills plugin, but went permanently silent once it was installed — and its nudges mixed CLI and in-REPL syntax. This PR fixes the wording and adds a staleness check.What's here
Consistent CLI nudges: both the "marketplace not registered" and "plugin not installed" tips now use
claude plugin marketplace add ObolNetwork/skills/claude plugin install obol@<marketplace>(previously one line was the in-REPL/plugin install …form).Update nudge: when the plugin is installed, the installed version (from
~/.claude/plugins/installed_plugins.json— v2 maps eachplugin@marketplacekey to an array of per-scope install records; the legacy single-object shape and the literal"unknown"version are tolerated) is compared against the released version (.claude-plugin/plugin.jsonon ObolNetwork/skills' default branch, fetched with a 2-second timeout and capped body read). A newer release prints:Never blocks, never nags on guesswork: any failure — no
claudein PATH, malformed config, unreachable GitHub, unknowable local version — stays silent. Timing unchanged: the tip remains the final output of a successfulstack up.Testing
Unit tests with fixtures mirroring the real Claude Code file shapes (marketplace lookup incl. a renamed marketplace resolving by repo, both installed-plugins formats,
"unknown"handling), a local test server for the manifest fetch (including 404-stays-silent), and a numeric version-compare table (1.9.0 < 1.10.0).🤖 Generated with Claude Code