chore(model): drop dead HasProviderConfigured#747
Closed
bussyjd wants to merge 3 commits into
Closed
Conversation
Zero callers anywhere (including tests) — flagged by the /v1 pipeline audit's dead-code sweep alongside WarnAndStripV1Suffix (removed in #745). Other deadcode-tool hits in internal/{buy,inference} are test-covered exported API and were left alone. Claude-Session: https://claude.ai/code/session_014YjPMViNrZ7zBVgUQzwEKk
bussyjd
enabled auto-merge (squash)
July 14, 2026 07:19
Two-vendor (GPT + Grok) audited deletions, intersection-only: - inference: dead ProbeEndpoint/ScanLocalEndpoints/DetectServerType/ ParseModelsResponse wrappers (live path is the *Context variants used by model discovery); tests retargeted to live functions - erc8004: superseded NewClient/Register/RegisterDetailed/SetAgentURI (+ETH/RegisterWithOpts/SubmitRegister); tests retargeted to the WithOpts variants - x402: ResolveAssetInfo/BuildV1Requirement/TokenSupportedOnChain (production uses ResolveAssetInfoForPayment/BuildV2Requirement/ ResolveToken); test coverage migrated, not dropped - hermes: hermesExecArgs legacy test adapter + dead List/Skills/ ResolveInstance; agentruntime/dns/stack/schemas/serviceoffercontroller zero-reference symbols; dead flow-lib shell functions - flow-11: fix stale diag capture (deploy/litellm -c x402-buyer -> deploy/x402-buyer, stale since the b68fc34 split) Held back by committee split or product decision: RouteRulesForOffer (golden-test seam), erc8004 SetMetadata, all TEE/CoCo + enclave + OpenClaw capabilities (kept intentionally, see #748). Claude-Session: https://claude.ai/code/session_014YjPMViNrZ7zBVgUQzwEKk
- pitfall 6 generalized: EVERY LiteLLM openai/ api_base must include /v1 (LiteLLM posts <api_base>/chat/completions verbatim); buyer-side tooling uses the opposite convention; discovery fixed in #745 - new pitfall 22: poisoned model group (two deployments, one bare api_base -> intermittent 404, no retry; GET /model/info vs CM is the decisive check) - new pitfall 23: buyer disconnect != no charge (hermes non-streaming path completes + settles after abort; keep runs short via spec.maxTurns; maxConcurrentRuns semantics; 4xx never settled) - skill: lessons table updated (poisoned model group, parserless QA endpoint -> relaunch with publisher-exact launcher), version 3.2.0 Claude-Session: https://claude.ai/code/session_014YjPMViNrZ7zBVgUQzwEKk
4 tasks
Contributor
Author
auto-merge was automatically disabled
July 14, 2026 10:50
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zero references anywhere including tests (its only grep hit was its own doc comment). Found by the dead-code sweep that accompanied the /v1 pipeline audit (#745, #746). Other
deadcodehits ininternal/buyandinternal/inferenceare exported, test-covered API — left untouched.https://claude.ai/code/session_014YjPMViNrZ7zBVgUQzwEKk