Skip to content

Add ability to observe the number of connections halibut opens for ea… - #717

Draft
pawelpabich wants to merge 3 commits into
mainfrom
pawel/halibut-per-sub-conns
Draft

Add ability to observe the number of connections halibut opens for ea…#717
pawelpabich wants to merge 3 commits into
mainfrom
pawel/halibut-per-sub-conns

Conversation

@pawelpabich

Copy link
Copy Markdown

…ch polling subscription

Are you a customer of Octopus Deploy? Please contact our support team so we can triage your PR, so that we can make sure it's handled appropriately.

Background

Results

Fixes https://github.com/OctopusDeploy/Issues/issues/... (optional public issue)

Fixes https://github.com/OctopusDeploy/ResearchAndDevelopment/issues/... (optional private issue)

See How we use GitHub Issues (including this flowchart

Before

Before

After

After

How to review this PR

Quality ✔️

Pre-requisites

  • I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
  • I have considered informing or consulting the right people, according to the ownership map.
  • I have considered appropriate testing for my change.

await IdentifyAsServerAsync(identity, cancellationToken);
await ProcessClientRequestsAsync(incomingRequestProcessor, cancellationToken);
break;
case RemoteIdentityType.Subscriber:

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved the connection limit enforcement closer to the code that it applies to.

  1. There is no need to perform work for other types of remote identities
  2. We were executing IdentifyAsServerAsync even for the default switch case, which results in an exception. This shows how easy it is to make a mistake if code that is case-specific is applied to all cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant