accounts: report errors syncing as errors#262
Open
mathstuf wants to merge 1 commit into
Open
Conversation
As "just" a warning, monitoring can miss problems such as out-of-date SSL certificate chains or fingerprints. Signed-off-by: Ben Boeckel <mathstuf@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As "just" a warning, monitoring can miss problems such as out-of-date SSL certificate chains or fingerprints.
Signed-off-by: Ben Boeckel mathstuf@gmail.com
As context, I have monitoring set up on my journal log and errors surface, but warnings are not. By raising this as an error, I can get notifications for errors syncing without also being inundated with warnings.
Tested by mucking with my fingerprint hashes and observing behavior in notifications.
This PR