fix: restore the deprecated 2-arg NSE selector - #1737
Merged
Merged
Conversation
5.6.0 dropped it as iOS 10 leftover. iOS 10 is the floor, and wrappers still call the sync path. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
|
could add tests |
fadi-george
approved these changes
Sep 8, 2026
Merged
This was referenced Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Put
didReceiveNotificationExtensionRequest:withMutableNotificationContent:back onOneSignalandOneSignalExtensionas a deprecated public wrapper.Details
Motivation
5.6.0 removed this selector in #1726 as unsupported iOS 10 code. The "iOS 10 only" comment meant NSE's floor is iOS 10, not that the method died on 11+. Wrappers and old
NotificationServicefiles still call the 2-arg form, so 5.6.0 is a compile break in a minor.It was deprecated in 3.5.0 (#934) because confirmed-delivery spreading needs
contentHandlerto keep the NSE alive after the banner shows. The 2-arg path is still the sync contract (nilhandler, no receipt delay). Deprecation is not the same as removal. Drop it in 6.0, not 5.6.x.Scope
.mwrappers onOneSignalandOneSignalExtensiononlynilTesting
Unit testing
None added. The internal handler never lost the 2-arg method, and that is what these wrappers call. Existing NSE handler tests cover that path.
Manual testing
Not device-tested. This restores a public selector so NSE files that still call it compile against 5.6.x. The 3-arg path is unchanged.
Affected code checklist
Checklist
Overview
Testing
Final pass
Made with Cursor