Skip to content

fix: [SDK-5191] correct lock screen visibility type - #1993

Closed
fadi-george wants to merge 1 commit into
mainfrom
fadi/sdk-5191
Closed

fix: [SDK-5191] correct lock screen visibility type#1993
fadi-george wants to merge 1 commit into
mainfrom
fadi/sdk-5191

Conversation

@fadi-george

Copy link
Copy Markdown
Collaborator

Description

One Line Summary

Correct the Android lockScreenVisibility notification property from string to number.

Details

Motivation

The native Android SDK provides lock screen visibility as a numeric value. The React Native type incorrectly declared it as a string, causing the public notification model to disagree with the runtime value.

Scope

Updates the Android notification data interface and public OSNotification property type. No notification processing or behavior changes.

Testing

Unit testing

Updated the OSNotification mapping test to verify the numeric value. vp test passes.

Manual testing

Not performed because this is a type correction with existing unit coverage and no runtime behavior change. vp check passes.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

Co-authored-by: Cursor <cursoragent@cursor.com>
@fadi-george
fadi-george requested a review from a team as a code owner September 9, 2026 22:09
@fadi-george fadi-george closed this Sep 9, 2026
@fadi-george
fadi-george deleted the fadi/sdk-5191 branch September 9, 2026 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant