Initial win event simplification - #706
Merged
Merged
Conversation
mcarans
requested review from
AnotherCommander,
Kaks,
KonstantinosSykas,
dsalt,
ericwalch,
jobi-wan,
kanthoney,
mwerle,
oocube and
phkb
as code owners
August 3, 2026 00:37
Contributor
Author
|
@phkb This was what you tested before #700 (comment). Did you have any issues with fullscreen with these changes? |
Contributor
|
Full screen works correctly in this version, as does the restoring of window size for non-full screen. |
Contributor
Author
Thanks for testing. if you approve the PR I'll merge it as a first working step |
phkb
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An initial Windows simplification
This doesn't fix anything on Linux (ie. Gnome resizing issue fixed in this draft PR #705 still exists in this PR)