ci: skip coverage checks without fresh flag uploads - #2635
Conversation
Do not gate unrelated components on carried-forward coverage when their workflows did not upload a report for the current commit. Preserve carryforward data, coverage targets, thresholds, and upload error handling. Validate the configuration with the official Codecov YAML validator.
|
This change fixes the false alarm, but does not guarantee a minimum overall coverage level for devtools. Under that requirement, this PR does not provide a complete solution on its own. Why did SVDConv fail despite the coverage improvement?The improvement was real:
The additional tests were present. The measurement data was outdated, not the code. What does this change affect?For all six components, the existing coverage requirements remain unchanged when a fresh report is uploaded. Without a fresh report, the corresponding status check is omitted. This prevents the false alarm described above, but has a limitation: an unexpectedly missing report is also excluded. Codecov does not distinguish between an intentionally skipped test run and a missing upload. See the Codecov documentation. What is still needed to protect overall coverage?Even before this PR, the overall status check was disabled with To enforce an overall coverage requirement, we also need:
Simply enabling the overall check would reproduce the same false alarm if it still uses outdated carried-forward reports. The remaining policy decision is: Should overall coverage stay above a fixed percentage (and if so, which one), or must it never decrease compared with |
Summary
Validation
Valid!.git diff --checkpassed. Onlycodecov.ymlchanges; no source or workflow changes.