Skip to content

chore(pyproject): cleaning unused dependencies (#217) - #321

Merged
guzmud merged 4 commits into
mainfrom
chore/217-clean-dependencies
Jul 28, 2026
Merged

chore(pyproject): cleaning unused dependencies (#217)#321
guzmud merged 4 commits into
mainfrom
chore/217-clean-dependencies

Conversation

@guzmud

@guzmud guzmud commented Jul 27, 2026

Copy link
Copy Markdown
Member

Proposed changes

  • Updating the list of dependencies
    • pyoaev\backends\protocol.py:11:5: DEP003 'typing_extensions' imported but it is a transitive dependency
      ➡️ unused dependency, deleting unrequired retro-compatibility with py38 and below and thus the need for this dependency
    • pyproject.toml: DEP002 'datefinder' defined as a dependency but not used in the codebase
      ➡️ not found in the codebase, to be deleted
    • pyproject.toml: DEP002 'python-magic' defined as a dependency but not used in the codebase
      ➡️ not found in the codebase, to be deleted
    • pyproject.toml: DEP002 'python-magic-bin' defined as a dependency but not used in the codebase
      ➡️ not found in the codebase, to be deleted
    • pyproject.toml: DEP002 'setuptools' defined as a dependency but not used in the codebase
      ➡️ to move to dev dependencies
    • pyproject.toml: DEP002 'cachetools' defined as a dependency but not used in the codebase
      ➡️ not found in the codebase, to be deleted
    • pyproject.toml: DEP002 'prometheus-client' defined as a dependency but not used in the codebase
      ➡️ not found in the codebase, to be deleted
    • pyproject.toml: DEP002 'opentelemetry-api' defined as a dependency but not used in the codebase
      ➡️ not found in the codebase, to be deleted
    • pyproject.toml: DEP002 'opentelemetry-sdk' defined as a dependency but not used in the codebase
      ➡️ not found in the codebase, to be deleted
    • pyproject.toml: DEP002 'dataclasses-json' defined as a dependency but not used in the codebase
      ➡️ not found in the codebase, to be deleted
    • scripts\release.py:6:1: DEP001 'OAEV_utils' imported but missing from the dependency definitions
      ➡️ unknown OAEV_utils?
  • reordering dependencies list (alphabetical order)
  • updating CircleCI so that dev requirements are not included in regular dependencies

Testing Instructions

  1. CircleCI install the pytest dependency
  2. Tests in CI (both CircleCI and Github Actions) don't fail

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

Copilot AI review requested due to automatic review settings July 27, 2026 13:56
@github-actions github-actions Bot added the filigran team Item from the Filigran team. label Jul 27, 2026
Dependency was a transitive one + pyproject points out 3.11 as min
version
@guzmud
guzmud force-pushed the chore/217-clean-dependencies branch from c8bbb1b to fd53da9 Compare July 27, 2026 13:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up pyproject.toml by removing a set of unused runtime dependencies and relocating build tooling (setuptools) into optional dev dependencies, and it simplifies Protocol importing in the backend protocol definitions consistent with the project’s requires-python = ">=3.11".

Changes:

  • Remove multiple unused runtime dependencies from [project].dependencies.
  • Move setuptools into [project.optional-dependencies].dev and add coverage to dev extras.
  • Simplify Protocol import in pyoaev/backends/protocol.py to use typing.Protocol unconditionally.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
pyproject.toml Removes unused runtime deps; adjusts dev extras (adds coverage, moves setuptools).
pyoaev/backends/protocol.py Simplifies Protocol import (now always from typing).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pyoaev/backends/protocol.py Outdated
Comment thread pyproject.toml
@guzmud
guzmud requested a review from Kakudou July 27, 2026 15:16

@Kakudou Kakudou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, TY !

Edit, i will look more in details for that oaev_utils, consider out-of-scope for now.

@guzmud
guzmud merged commit ab7e19f into main Jul 28, 2026
17 checks passed
@guzmud
guzmud deleted the chore/217-clean-dependencies branch July 28, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: remove unused requirements and add missing requirement in pyproject.toml

4 participants