Skip to content

Update undici to 7.29.0 - #24611

Merged
wing328 merged 1 commit into
masterfrom
undici
Aug 5, 2026
Merged

Update undici to 7.29.0#24611
wing328 merged 1 commit into
masterfrom
undici

Conversation

@wing328

@wing328 wing328 commented Aug 5, 2026

Copy link
Copy Markdown
Member

for #24594

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Bumps undici to ^7.29.0 for TypeScript Node clients using the fetch API to pick up the latest fixes and keep generated packages consistent.

  • Dependencies
    • Updated modules/openapi-generator/src/main/resources/typescript/package.mustache to use undici ^7.29.0 for Node targets.
    • Updated sample TypeScript client package.json files to undici ^7.29.0.

Written for commit e4b8fe0. Summary will update on new commits.

Review in cubic

@wing328 wing328 added this to the 7.25.0 milestone Aug 5, 2026
@wing328 wing328 changed the title update undici to 7.29.0 Update undici to 7.29.0 Aug 5, 2026
@wing328
wing328 marked this pull request as ready for review August 5, 2026 07:15

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 7 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="samples/openapi3/client/petstore/typescript/builds/default/package.json">

<violation number="1" location="samples/openapi3/client/petstore/typescript/builds/default/package.json:35">
P2: The undici version in these sample package.json files was bumped to ^7.29.0, but the committed package-lock.json files next to them were not regenerated and still pin older undici versions (^7.16.0 for the `default` build and ^7.28.0 for the `inversify` build, resolved to those exact versions). Since `npm ci` installs from the lock file, the intended 7.29.0 bump would not actually take effect in these samples (and `npm install` would later rewrite the locks, making the committed state inconsistent). Please regenerate/commit the package-lock.json files in the affected builds (and the tests directories that depend on them) so they reflect ^7.29.0, keeping the generated samples consistent as intended.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

},
"dependencies": {
"undici": "^7.28.0",
"undici": "^7.29.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: The undici version in these sample package.json files was bumped to ^7.29.0, but the committed package-lock.json files next to them were not regenerated and still pin older undici versions (^7.16.0 for the default build and ^7.28.0 for the inversify build, resolved to those exact versions). Since npm ci installs from the lock file, the intended 7.29.0 bump would not actually take effect in these samples (and npm install would later rewrite the locks, making the committed state inconsistent). Please regenerate/commit the package-lock.json files in the affected builds (and the tests directories that depend on them) so they reflect ^7.29.0, keeping the generated samples consistent as intended.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At samples/openapi3/client/petstore/typescript/builds/default/package.json, line 35:

<comment>The undici version in these sample package.json files was bumped to ^7.29.0, but the committed package-lock.json files next to them were not regenerated and still pin older undici versions (^7.16.0 for the `default` build and ^7.28.0 for the `inversify` build, resolved to those exact versions). Since `npm ci` installs from the lock file, the intended 7.29.0 bump would not actually take effect in these samples (and `npm install` would later rewrite the locks, making the committed state inconsistent). Please regenerate/commit the package-lock.json files in the affected builds (and the tests directories that depend on them) so they reflect ^7.29.0, keeping the generated samples consistent as intended.</comment>

<file context>
@@ -32,7 +32,7 @@
   },
   "dependencies": {
-    "undici": "^7.28.0",
+    "undici": "^7.29.0",
     "@types/node": "^20.17.10",
     "form-data": "^4.0.4",
</file context>

@wing328
wing328 merged commit 2be3047 into master Aug 5, 2026
41 of 45 checks passed
@wing328
wing328 deleted the undici branch August 5, 2026 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant