Conversation
There was a problem hiding this comment.
1 issue found across 7 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="samples/openapi3/client/petstore/typescript/builds/default/package.json">
<violation number="1" location="samples/openapi3/client/petstore/typescript/builds/default/package.json:35">
P2: The undici version in these sample package.json files was bumped to ^7.29.0, but the committed package-lock.json files next to them were not regenerated and still pin older undici versions (^7.16.0 for the `default` build and ^7.28.0 for the `inversify` build, resolved to those exact versions). Since `npm ci` installs from the lock file, the intended 7.29.0 bump would not actually take effect in these samples (and `npm install` would later rewrite the locks, making the committed state inconsistent). Please regenerate/commit the package-lock.json files in the affected builds (and the tests directories that depend on them) so they reflect ^7.29.0, keeping the generated samples consistent as intended.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| }, | ||
| "dependencies": { | ||
| "undici": "^7.28.0", | ||
| "undici": "^7.29.0", |
There was a problem hiding this comment.
P2: The undici version in these sample package.json files was bumped to ^7.29.0, but the committed package-lock.json files next to them were not regenerated and still pin older undici versions (^7.16.0 for the default build and ^7.28.0 for the inversify build, resolved to those exact versions). Since npm ci installs from the lock file, the intended 7.29.0 bump would not actually take effect in these samples (and npm install would later rewrite the locks, making the committed state inconsistent). Please regenerate/commit the package-lock.json files in the affected builds (and the tests directories that depend on them) so they reflect ^7.29.0, keeping the generated samples consistent as intended.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At samples/openapi3/client/petstore/typescript/builds/default/package.json, line 35:
<comment>The undici version in these sample package.json files was bumped to ^7.29.0, but the committed package-lock.json files next to them were not regenerated and still pin older undici versions (^7.16.0 for the `default` build and ^7.28.0 for the `inversify` build, resolved to those exact versions). Since `npm ci` installs from the lock file, the intended 7.29.0 bump would not actually take effect in these samples (and `npm install` would later rewrite the locks, making the committed state inconsistent). Please regenerate/commit the package-lock.json files in the affected builds (and the tests directories that depend on them) so they reflect ^7.29.0, keeping the generated samples consistent as intended.</comment>
<file context>
@@ -32,7 +32,7 @@
},
"dependencies": {
- "undici": "^7.28.0",
+ "undici": "^7.29.0",
"@types/node": "^20.17.10",
"form-data": "^4.0.4",
</file context>
for #24594
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Bumps
undicito ^7.29.0 for TypeScript Node clients using the fetch API to pick up the latest fixes and keep generated packages consistent.modules/openapi-generator/src/main/resources/typescript/package.mustacheto useundici^7.29.0 for Node targets.package.jsonfiles toundici^7.29.0.Written for commit e4b8fe0. Summary will update on new commits.