Fix exact presentation media timing#256
Closed
abrichr wants to merge 1 commit into
Closed
Conversation
abrichr
marked this pull request as ready for review
July 26, 2026 10:55
abrichr
force-pushed
the
agent/exact-presentation-duration
branch
from
July 26, 2026 10:56
b1acc08 to
7a883e0
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
max(PTS + duration)), not the final sample startWhy
The former VFR WebM path retained decoded frame PTS beyond the container's declared stream duration. Browsers could therefore stop before the terminal VERIFIED/HALTED hold even though the frame inventory existed. A frame timestamp marks a sample start, so using the final PTS as the duration was also one sample short.
Impact
New public presentation packs carry byte-bound MP4 media whose decoded PTS inventory and full duration agree with the overlay timeline and browser parser. No runtime execution or evidence semantics change.
Validation
has_b_frames=0,time_base=1/1000000