Skip to content

Polish shared evidence player overlay #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abrichr merged 2 commits into from
Jul 26, 2026
Merged

Polish shared evidence player overlay #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdd73eb
Polish shared evidence player overlay
abrichr Jul 26, 2026
2be28b0
Align mobile playback focus order
abrichr Jul 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions components/EvidenceMediaPlayer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,6 @@ export default function EvidenceMediaPlayer({
className={styles.capsule}
aria-label={`OpenAdapt ${accessibleModeLabel.toLowerCase()} in ${application}`}
data-overlay-kind="canonical-runtime-state"
data-interactive={overlayEvidenceHref ? 'true' : undefined}
>
<span className={styles.header}>
<span className={styles.brand}>
Expand Down Expand Up @@ -351,11 +350,6 @@ export default function EvidenceMediaPlayer({
{presentation.explanation}
</span>
)}
{overlayEvidenceHref && (
<a className={styles.evidenceLink} href={overlayEvidenceHref}>
View execution evidence
</a>
)}
</div>
)}
</div>
Expand Down Expand Up @@ -397,6 +391,15 @@ export default function EvidenceMediaPlayer({
) : (
<span className={styles.time}>Looping evidence clip</span>
)}
{overlayEvidenceHref && (
<a
className={styles.evidenceLink}
href={overlayEvidenceHref}
aria-label={`View evidence for ${application} ${accessibleModeLabel.toLowerCase()}`}
>
Evidence
</a>
)}
<button
type="button"
aria-label="Enter full screen"
Expand Down
49 changes: 37 additions & 12 deletions components/EvidenceMediaPlayer.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,6 @@
backdrop-filter: blur(10px);
}

.capsule[data-interactive='true'] {
pointer-events: auto;
}

.stage[data-overlay-placement='bottom-left'] .capsule {
left: 10px;
}
Expand Down Expand Up @@ -226,16 +222,18 @@
}

.evidenceLink {
justify-self: start;
min-height: 44px;
padding: 8px 12px;
display: inline-flex;
min-height: 36px;
flex: 0 0 auto;
align-items: center;
padding: 0 10px;
border: 1px solid rgba(255, 255, 255, 0.22);
border-radius: 7px;
background: rgba(255, 255, 255, 0.08);
color: #f4f7f2;
font-size: 12px;
font-size: 11px;
font-weight: 700;
line-height: 28px;
line-height: 1.2;
text-decoration: none;
}

Expand Down Expand Up @@ -342,12 +340,39 @@
}

.controls {
flex-wrap: wrap;
display: grid;
grid-template-columns: 44px minmax(0, 1fr) auto 44px;
grid-template-rows: auto auto;
gap: 4px 8px;
}

.controls > button:first-child {
grid-column: 1;
grid-row: 1;
}

.controls input {
order: 3;
min-width: 100%;
grid-column: 2 / 5;
grid-row: 1;
width: 100%;
min-width: 0;
}

.time {
grid-column: 1 / 3;
grid-row: 2;
margin-left: 0;
}

.evidenceLink {
grid-column: 3;
grid-row: 2;
min-height: 44px;
}

.controls > button:last-child {
grid-column: 4;
grid-row: 2;
}
}

Expand Down
2 changes: 1 addition & 1 deletion cypress/e2e/reference-demo.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ describe('shared real-application demo', () => {
cy.get('@player')
.should('have.attr', 'data-decoded-frame-index', '1')
.then(($player) => $player.find('video')[0].pause())
.should('contain.text', 'View execution evidence')
.should('contain.text', 'Evidence')
.and('contain.text', 'Application network traffic observed')
.find('[data-decoded-frame-index="1"]')
.should('be.visible')
Expand Down
Loading