Skip to content

Fix DEC and longitude conversions in Meade commands #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GJayLG wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix DEC and longitude conversions in Meade commands #296

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8eae5e9
Fix DEC and longitude conversions in Meade commands
GJayLG Aug 5, 2026
a3cce7e
style: clang-format
GJayLG Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 29 additions & 8 deletions src/MeadeCommandProcessor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,12 +97,26 @@ meade::RaCoordinate raFrom(const DayTime &t)
};
}

Declination decToInternal(const meade::DecCoordinate &d)
{
long seconds = labs(static_cast<long>(d.degrees)) * 3600L + d.minutes * 60L + d.seconds;
return Declination::FromSeconds(d.degrees < 0 ? -seconds : seconds);
}

meade::DecCoordinate decFrom(const Declination &d)
{
const long celestialSeconds = inNorthernHemisphere ? 90L * 3600L - labs(d.getTotalSeconds()) : -90L * 3600L + labs(d.getTotalSeconds());
const long absoluteSeconds = labs(celestialSeconds);
int16_t degrees = static_cast<int16_t>(absoluteSeconds / 3600L);
if (celestialSeconds < 0)
{
degrees = -degrees;
}

return meade::DecCoordinate {
static_cast<int16_t>(d.getHours()),
static_cast<uint8_t>(d.getMinutes()),
static_cast<uint8_t>(d.getSeconds()),
degrees,
static_cast<uint8_t>((absoluteSeconds / 60L) % 60L),
static_cast<uint8_t>(absoluteSeconds % 60L),
};
}
} // namespace
Expand Down Expand Up @@ -160,9 +174,16 @@ meade::MeadeLatitude MeadeCommandProcessor::onSiteLatitude()
meade::MeadeLongitude MeadeCommandProcessor::onSiteLongitude()
{
const Longitude lon = _mount->longitude();
long secs = labs(static_cast<long>(lon.getTotalSeconds()));
int16_t deg = static_cast<int16_t>(secs / 3600L);
uint8_t min = static_cast<uint8_t>((secs / 60L) % 60L);
if (lon.getTotalHours() > 0)
{
deg = -deg;
}
return meade::MeadeLongitude {
static_cast<int16_t>(lon.getHours()),
static_cast<uint8_t>(lon.getMinutes()),
deg,
min,
};
}

Expand Down Expand Up @@ -248,7 +269,7 @@ void MeadeCommandProcessor::onSyncToTarget()
/////////////////////////////
bool MeadeCommandProcessor::onSetTargetDec(meade::DecCoordinate dec)
{
_mount->targetDEC() = Declination(static_cast<int>(dec.degrees), static_cast<int>(dec.minutes), static_cast<int>(dec.seconds));
_mount->targetDEC() = decToInternal(dec);
LOG(DEBUG_MEADE, "[MEADE]: SetInfo: Received Target DEC: %s", _mount->targetDEC().ToString());
return true;
}
Expand Down Expand Up @@ -282,7 +303,7 @@ bool MeadeCommandProcessor::onSetHourAngle(uint8_t hours, uint8_t minutes)

bool MeadeCommandProcessor::onSyncCoordinates(meade::DecCoordinate dec, meade::RaCoordinate ra)
{
Declination decValue(static_cast<int>(dec.degrees), static_cast<int>(dec.minutes), static_cast<int>(dec.seconds));
Declination decValue = decToInternal(dec);
DayTime raValue(static_cast<int>(ra.hours), static_cast<int>(ra.minutes), static_cast<int>(ra.seconds));
_mount->syncPosition(raValue, decValue);
return true;
Expand All @@ -296,7 +317,7 @@ bool MeadeCommandProcessor::onSetSiteLatitude(meade::MeadeLatitude lat)

bool MeadeCommandProcessor::onSetSiteLongitude(meade::MeadeLongitude lon)
{
_mount->setLongitude(Longitude(static_cast<int>(lon.degrees), static_cast<int>(lon.minutes), 0));
_mount->setLongitude(Longitude(-static_cast<int>(lon.degrees), static_cast<int>(lon.minutes), 0));
return true;
}

Expand Down
Loading