[Edge] adds a full login form to edge - #3958
Open
chpoulter wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #3958 +/- ##
=============================================
- Coverage 55.72% 55.34% -0.38%
- Complexity 19111 19439 +328
=============================================
Files 3674 3842 +168
Lines 171940 177253 +5313
Branches 14153 14802 +649
=============================================
+ Hits 95802 98082 +2280
- Misses 72367 75289 +2922
- Partials 3771 3882 +111 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a full login form for edge, so it gets possible to login with user and password.
The changes in AuthenticationRequestHandler make it possible to add an own UserService with a higher service ranking for handling authentication requests. The code should be transparent, so everything should work as before, if you do not add an own UserService.
In the UI I added a setting for the login form type - with fullLogin you can decide, if you want a username+password login or just a password login as before. Only password is also the default.
I've written this code as I only run an edge and no backend and I can attach it to ldap this way. But of course you could use/write other UserService implementations for adapting different authentication systems.
The patch is a diff against main and I will keep it in sync to main.