Skip to content

[Edge] adds a full login form to edge - #3958

Open
chpoulter wants to merge 1 commit into
OpenEMS:developfrom
chpoulter:feature/EdgeFullLoginForm
Open

[Edge] adds a full login form to edge#3958
chpoulter wants to merge 1 commit into
OpenEMS:developfrom
chpoulter:feature/EdgeFullLoginForm

Conversation

@chpoulter

Copy link
Copy Markdown
Contributor

I've added a full login form for edge, so it gets possible to login with user and password.

The changes in AuthenticationRequestHandler make it possible to add an own UserService with a higher service ranking for handling authentication requests. The code should be transparent, so everything should work as before, if you do not add an own UserService.

In the UI I added a setting for the login form type - with fullLogin you can decide, if you want a username+password login or just a password login as before. Only password is also the default.

I've written this code as I only run an edge and no backend and I can attach it to ldap this way. But of course you could use/write other UserService implementations for adapting different authentication systems.

The patch is a diff against main and I will keep it in sync to main.

@codecov

codecov Bot commented Sep 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3958      +/-   ##
=============================================
- Coverage      55.72%   55.34%   -0.38%     
- Complexity     19111    19439     +328     
=============================================
  Files           3674     3842     +168     
  Lines         171940   177253    +5313     
  Branches       14153    14802     +649     
=============================================
+ Hits           95802    98082    +2280     
- Misses         72367    75289    +2922     
- Partials        3771     3882     +111     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant