Add ability to make error as a value. - #3559
Open
ihsansfd wants to merge 1 commit into
Open
Conversation
ihsansfd
force-pushed
the
f/error-as-a-value-even-when-error-occurs
branch
from
September 5, 2026 16:50
445782b to
ea9a37e
Compare
ihsansfd
force-pushed
the
f/error-as-a-value-even-when-error-occurs
branch
from
September 12, 2026 09:42
ea9a37e to
cb297c8
Compare
ihsansfd
changed the title
ihsansfd
marked this pull request as ready for review
September 12, 2026 09:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solving issue #2944.
Unfortunately for status code 204 and 404, all decoders are implemented to return empty body. I don't know what's the best way to handle this, so I leave it as is (make them keep returning empty body to avoid backward incompatibility). Any guideline to handle this better is much appreciated.
This is my first PR in this repo, do tell me if there is anything need to be fixed. Thanks 🙏