fix(recording): recorded files now appear in Recordings list#25
Merged
Conversation
…d Windows - FfmpegSubprocessRecorder + FfmpegSubprocessClipExporter shell out to runtimes/win-x64/native/ffmpeg.exe, but only the FFmpeg *.dll were bundled — so packaged win-x64 builds failed with "cannot find ffmpeg" (fell back to PATH) - fetch-ffmpeg.ps1 now copies ffmpeg.exe from the shared build (tiny; uses the DLLs already shipped) - Video.csproj ships runtimes/win-x64/native/ffmpeg.exe to the output (excluded from single-file, kept loose next to the exe like the DLLs)
- FfmpegRecordingSession parses ffmpeg's "Opening '<path>' for writing" line to fire Started/SegmentRotated, which is what writes the Recordings DB row - that line is logged at AV_LOG_VERBOSE, but ffmpeg ran at -loglevel warning, so it was suppressed → no Started event → no DB row (file on disk, list empty) - bump to -loglevel verbose so segment opens are captured
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fire Started/SegmentRotated, which is what writes the Recordings DB row
it was suppressed → no Started event → no DB row (file on disk, list empty)
Related
Type
Checklist
TreatWarningsAsErrors=true).dotnet test); new Core logic has unit tests.AppreferencesCoreonly (Infrastructure / Video / Devices wired via DI in a head).Platforms tested
Screenshots / notes