fix: make ONVIF/Majestic/audio work with real OpenIPC cameras#29
Merged
Conversation
- Majestic: detect via config.json (info.json is the web UI's HTML on some firmwares) and tolerate a non-JSON info.json instead of throwing - ONVIF: 8s WCF binding timeouts + catch TimeoutException so a broken onvif_simple_server fails fast rather than hanging the probe for 60s - Android: enable opus/pcm_mulaw/pcm_alaw FFmpeg decoders so camera audio plays on the phone (requires rebuilding the native libs) - Grid: Back from a camera returns to the originating page (grid vs library)
- Desktop: persist and restore main window position/size/maximized state - Grid: add 4x4 and 5x5 layouts (up to 25 tiles) - Video: route FFmpeg native av_log to ILogger and append the real cause (401, connection refused, ...) to FfmpegException messages - Analytics: map detection boxes into the letterboxed video rect via CameraTileViewModel.SourceAspect
- ShowRawConfigEditorAsync takes a validateJson flag; the Edit-over-SSH path passes false so Apply no longer rejects majestic.yaml as "invalid JSON" and silently refuses to save - drop JSON syntax highlighting when editing YAML
- IAudioBackchannelClient.ProbeAsync: lightweight OPTIONS+DESCRIBE capability check (no SETUP/PLAY); RtspBackchannelClient implements it - camera page probes the backchannel once on activation and shows a hint when the camera advertises none, instead of a silently disappearing talk button
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
firmwares) and tolerate a non-JSON info.json instead of throwing
onvif_simple_server fails fast rather than hanging the probe for 60s
plays on the phone (requires rebuilding the native libs)
(401, connection refused, ...) to FfmpegException messages
Related
Type
Checklist
TreatWarningsAsErrors=true).dotnet test); new Core logic has unit tests.AppreferencesCoreonly (Infrastructure / Video / Devices wired via DI in a head).Platforms tested
Screenshots / notes