Skip to content

[com1] make no asset value a parameter to be set - #1324

Merged
fso42 merged 1 commit into
masterfrom
moveToIni
Aug 31, 2026
Merged

[com1] make no asset value a parameter to be set#1324
fso42 merged 1 commit into
masterfrom
moveToIni

Conversation

@awirb

@awirb awirb commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

PR Checklist

Please confirm before requesting review:

  • I ran pytest locally without fails
  • I added/updated tests where needed
  • I updated documentation where needed

Confirm before the final merge/rebase into master

  • Commits are sensibly squashed and rebased onto latest master
  • Standardtest run without difference (with recompiled cython code)

@awirb
awirb requested review from ahuber-bfw and fso42 August 5, 2026 08:37
@awirb awirb self-assigned this Aug 5, 2026
@awirb awirb added the featureRequest ideas or functions that would be useful label Aug 5, 2026
@qltysh

qltysh Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Qlty


Coverage Impact

This PR will not change total coverage.

Modified Components (1)

RatingComponent% Diff
Coverage rating: C Coverage rating: C
com1DFA100.0%

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
Coverage rating: D Coverage rating: D
avaframe/com1DFA/particleTools.py100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@ahuber-bfw ahuber-bfw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funktioniert bei mir

  • hab noch das runScript minimal angepasst, damit man auswählen kann ob '.tif' oder '.asc' als output.
  • sonst Doku noch anpassen?

Comment thread avaframe/com1DFA/particleTools.py Outdated
Comment thread avaframe/com1DFA/particleTools.py Outdated
@fso42 fso42 changed the title make no asset value a parameter to be set [com1] make no asset value a parameter to be set Aug 12, 2026
@qltysh

qltysh Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Analysis for project AvaFrame

❌ 1 blocking issue (1 total)

Tool Category Rule Count
black Style Incorrect formatting, autoformat by running qlty fmt. 1

@qltysh one-click actions:

  • Auto-fix formatting (qlty fmt && git push)

@awirb
awirb requested a review from fso42 August 31, 2026 08:15
add output file format (.asc, .tif) as option to runParticles.. runscript

changed default back to -1

set -1 default value no asset class

change comment

update docu
@fso42

fso42 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Standardtests ok, apart from know com5

@fso42
fso42 merged commit 09b9ae9 into master Aug 31, 2026
5 of 7 checks passed
@fso42
fso42 deleted the moveToIni branch August 31, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

featureRequest ideas or functions that would be useful

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants