Skip to content

Change error map to handle templated error messages from backend - #6483

Merged
Elblinator merged 7 commits into
OpenSlides:mainfrom
luisa-beerboom:b-3674-change-error-map-to-make-new-error-messages-translatable
Aug 18, 2026
Merged

Change error map to handle templated error messages from backend#6483
Elblinator merged 7 commits into
OpenSlides:mainfrom
luisa-beerboom:b-3674-change-error-map-to-make-new-error-messages-translatable

Conversation

@luisa-beerboom

@luisa-beerboom luisa-beerboom commented Aug 4, 2026

Copy link
Copy Markdown
Member

Result of OpenSlides/openslides-backend#3674
Needs OpenSlides/openslides-backend#3705 to work

This probably won't work until what @bastianjoel wrote in #6483 (review) is done

@luisa-beerboom luisa-beerboom added the enhancement General enhancement which is neither bug nor feature label Aug 4, 2026

@bastianjoel bastianjoel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't like extending this.

We already have https://ngx-translate.org/getting-started/translating-your-components/#with-parameters available in feature/vote via 4a32f08#diff-27642ca8b5c52c5d46eb8ea14c441a142374e0f4a41f12bcace2c4b6a1561756.

Also #6120 which could be used to parse more generic error strings is already implemented at pipe level there.

Please check if those things would help. Maybe together with a new action error response format (e.g. something like [{ error: 'format_error', params: { field: 'is_active' }}]).
If it helps I can cherry pick those things to main and if needed add a service for #6120.

Comment thread client/src/app/gateways/error-mapping/error-map-utils.ts Outdated

@bastianjoel bastianjoel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread client/src/app/gateways/error-mapping/error-map.service.ts Outdated
@bastianjoel bastianjoel added the waiting Waiting for some other PR/feature; more details in comments label Aug 5, 2026
@luisa-beerboom luisa-beerboom changed the title Change error map to make new json upload validation errors translatable Change error map to handle templated error messages from backend Aug 6, 2026
@bastianjoel bastianjoel removed their assignment Aug 13, 2026
@bastianjoel

Copy link
Copy Markdown
Member

Necessary changes added to main and merged into this PR.

@bastianjoel bastianjoel removed the waiting Waiting for some other PR/feature; more details in comments label Aug 13, 2026
@Elblinator Elblinator added the waiting Waiting for some other PR/feature; more details in comments label Aug 17, 2026
@Elblinator

Elblinator commented Aug 17, 2026

Copy link
Copy Markdown
Member

waiting until backend is ready to be merged/merged

@Elblinator

Copy link
Copy Markdown
Member

This PR should be mergable without breaking anything else

@Elblinator
Elblinator enabled auto-merge (squash) August 18, 2026 09:12
@Elblinator Elblinator removed the waiting Waiting for some other PR/feature; more details in comments label Aug 18, 2026
@Elblinator
Elblinator merged commit a588b24 into OpenSlides:main Aug 18, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement General enhancement which is neither bug nor feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants