Skip to content

Fix: add missing name props on inputs - #336

Merged
smarcet merged 4 commits into
mainfrom
fix/add-missing-name-props-on-inputs
Sep 7, 2026
Merged

Fix: add missing name props on inputs#336
smarcet merged 4 commits into
mainfrom
fix/add-missing-name-props-on-inputs

Conversation

@santipalenque

@santipalenque santipalenque commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

https://app.clickup.com/t/9014802374/86baqq2n5

Summary by CodeRabbit

  • New Features

    • Form inputs now support and preserve field names across text editors, upload controls, select fields, and asynchronous selects.
    • Formik-connected inputs now correctly associate rendered controls with their corresponding form fields.
  • Chores

    • Updated the package version to 5.0.60-beta.0.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: a684ee6e-d9c7-416d-92fc-9ceabad25a03

📥 Commits

Reviewing files that changed from the base of the PR and between c274ea7 and 9265974.

📒 Files selected for processing (8)
  • package.json
  • src/components/inputs/editor-input-v3.js
  • src/components/inputs/upload-input-v3/index.js
  • src/components/mui/addon-type-select.js
  • src/components/mui/formik-inputs/mui-formik-addon-type-select.js
  • src/components/mui/formik-inputs/mui-formik-async-select.js
  • src/components/mui/formik-inputs/mui-formik-text-editor.js
  • src/components/mui/formik-inputs/sponsorship-summit-select-mui.js

📝 Walkthrough

Walkthrough

The change adds name prop support and forwarding across editor, upload, and MUI/Formik input components. The package version changes from 5.0.58 to 5.0.60-beta.0.

Changes

Field name propagation

Layer / File(s) Summary
Public input contracts
src/components/inputs/editor-input-v3.js, src/components/inputs/upload-input-v3/index.js
TextEditorV3 and UploadInputV3 accept name and apply it to their rendered elements.
MUI and Formik wiring
src/components/mui/addon-type-select.js, src/components/mui/formik-inputs/*, src/components/mui/formik-inputs/sponsorship-summit-select-mui.js
Formik field names now reach the underlying MUI selects, autocomplete text field, and text editor.
Package release metadata
package.json
The package version changes to 5.0.60-beta.0.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: tomrndom, smarcet

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/add-missing-name-props-on-inputs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@smarcet smarcet left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet
smarcet merged commit f58aea3 into main Sep 7, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants