Compatability updates for parcelsv4 - #50
Open
wyatt-fluidnumerics wants to merge 7 commits into
Open
Conversation
…celsv4 compatability in moi benchmarking
for more information, see https://pre-commit.ci
erikvansebille
requested changes
Aug 13, 2026
erikvansebille
left a comment
erikvansebille
left a comment
Member
There was a problem hiding this comment.
Looks good; just one small change suggested below
Comment on lines
65
to
68
| if interpolator == "XLinear": | ||
| fieldset.U.interp_method = XLinear | ||
| fieldset.V.interp_method = XLinear | ||
| fieldset.UV.interp_method = XLinear_Velocity() | ||
| else: | ||
| raise ValueError(f"Unknown interpolator: {interpolator}") |
Member
There was a problem hiding this comment.
This is old code from when we didn't have a working CGrid_Velocity interpolator yet. I would now simply use the default interpolator that comes with the FieldSet
fluidnumericsJoe
approved these changes
Aug 13, 2026
fluidnumericsJoe
left a comment
fluidnumericsJoe
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Just one question - with the change in results.json, I'm assuming this is reflective of you running the benchmarks with the changes on this branch, yeah?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of the PR is to update the current benchmarking suite to work with the most up to date version of parcels v4. This PR achieves this goal in the following ways:
.to_windowed_array()is called on benchmarking field sets.