Add support for Darkness Enthroned and Atziri's Splendour augment mods#2343
Open
LocalIdentity wants to merge 1 commit into
Open
Add support for Darkness Enthroned and Atziri's Splendour augment mods#2343LocalIdentity wants to merge 1 commit into
LocalIdentity wants to merge 1 commit into
Conversation
Add support for the mod on Darkness Enthroned `This item gains bonuses from Socketed Items as though it was x` and `This item gains bonuses from Socketed Soul Cores as though it was also x` Moved some of the rune or socket checks into functions so they can be reused elsewhere Atziri's Spendour shows the added soul core stats in the dropdown tooltip Didn't use ModParser for the lines as it then needs to do extra loops through each item so opted for a simpler approach in Item.lua Item's tab update is required to the rune list is updated when you change variants on Atziri's Splendour
LocalIdentity
added
enhancement
LocalIdentity
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2342
Supersedes #2310
Description of the problem being solved:
Add support for the mod on Darkness Enthroned and added rune slots for it
This fixes the issue where no runes were on the item so the augment effect mod was infinitely scaling
Moved some of the rune or socket checks into functions so they can be reused elsewhere
Atziri's Spendour shows the added soul core stats in the dropdown tooltip
Didn't use ModParser for the lines as it then needs to do extra loops through each item so opted for a simpler approach in Item.lua
Item's tab update is required to the rune list is updated when you change variants on Atziri's Splendour
Link to a build that showcases this PR:
https://maxroll.gg/poe2/pob/ev4ny0tu
Before screenshot:
After screenshot: