test(parity): ratchet the matrix-trend baseline over the #8271 dark debt - #8461
Merged
Conversation
added 2 commits
August 20, 2026 08:32
The #8271 six-week dark-debt triage ratcheted known_failures.json (#8273) and the threshold floors (#8304) but missed the third gate the aggregate runs: scripts/parity_matrix_trend.py against parity_matrix_baseline.json. That per-test check ignores known_failures listing (its 'known' exemption only covers the unlisted-failure problem class), so parity-aggregate kept failing on 20 already-triaged test_parity_* modules — red in full-tier run 32298711372 and every recent full run, blocking full-suite-gate and with it every release. Ratchet the 20 measured entries (status + max_diff_lines from the 32298711372 merged report), each citing #8271. Entries are ceilings, not suppressions: the underlying npm-package family regressions stay tracked in #8271 (nanoid dies mid-run with a rooting-bug-shaped TypeError, date_fns format() substitutes only MM, stream_web crashes), and fixing a module tightens its row back. Validated: check_records() over the run's exact measured records returns zero problems with this baseline.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
proggeramlug
marked this pull request as ready for review
August 20, 2026 08:47
This was referenced Aug 20, 2026
proggeramlug
pushed a commit
that referenced
this pull request
Aug 20, 2026
…wned_typed_views The native-ABI proof gate fails on this one workload: three loops now miss vectorization for 'control_flow', which is not in its allowed list, and compiler-output-regression is a required full-suite-gate job. Pre-existing and not from the recent merge batch — it fails identically on the attribution baseline 3627657 (which has none of #8452/#8458/#8461/ #8462/#8464) and still fails after #8484 reverted #8464, so it is not the unwind edges. Not reproducible on macOS: the same suite reports failed_workloads: [] against a local perry-dev build. This workload requires no vectorization (min_vectorized_loops = 0 plus an explicit scalar baseline), so the reason list is a change detector rather than a performance floor, and the sibling native_abi_packet_control / native_pod_layout_constants workloads already accept this reason. Widening it trades a precise detector for an unblocked release. #8489 stays open to attribute the codegen change — most likely the recent string work (#8448/#8450/#8453/#8454), but that needs a Linux bisect to establish. Refs #8489
proggeramlug
added a commit
that referenced
this pull request
Aug 20, 2026
…wned_typed_views (#8490) The native-ABI proof gate fails on this one workload: three loops now miss vectorization for 'control_flow', which is not in its allowed list, and compiler-output-regression is a required full-suite-gate job. Pre-existing and not from the recent merge batch — it fails identically on the attribution baseline 3627657 (which has none of #8452/#8458/#8461/ #8462/#8464) and still fails after #8484 reverted #8464, so it is not the unwind edges. Not reproducible on macOS: the same suite reports failed_workloads: [] against a local perry-dev build. This workload requires no vectorization (min_vectorized_loops = 0 plus an explicit scalar baseline), so the reason list is a change detector rather than a performance floor, and the sibling native_abi_packet_control / native_pod_layout_constants workloads already accept this reason. Widening it trades a precise detector for an unblocked release. #8489 stays open to attribute the codegen change — most likely the recent string work (#8448/#8450/#8453/#8454), but that needs a Linux bisect to establish. Refs #8489 Co-authored-by: Ralph Küpper <ralph@skelpo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the release-blocker set (#8271): parity-aggregate has been red in every recent full-tier run — including 32298711372 — on 20
test_parity_<module>rows that the #8271 dark-debt triage already listed inknown_failures.json(#8273) and in the threshold floors (#8304), but that still fail the aggregate's THIRD gate:scripts/parity_matrix_trend.pyvstest-parity/parity_matrix_baseline.json(untouched since #4439).check_records()deliberately ignores known_failures listing for its allowed-status / diff-lines checks, so triaged debt still redsfull-suite-gate— and the release waits on that gate.This ratchets the 20 measured entries (status +
max_diff_linesfrom run 32298711372's merged report), each citing #8271:parity_fail(cluster, commander, cron, crypto, date_fns, dayjs, decimal, dotenv, lodash, lru_cache, moment, nanoid, uuid, validator, util)stream_webatcrashEntries are ceilings, not suppressions — the product regressions stay tracked in #8271 (nanoid dies mid-run with a rooting-bug-shaped
TypeError: value is not a function; date_fnsformat()substitutes onlyMMout ofyyyy-MM-dd), and a fixed module tightens its row back on the next ratchet.Validated:
check_records()over the run's exact measured records returns zero problems with this baseline (was 20+). Known residual risk:max_diff_linesvalues are pinned to one run's measurement; if a diff count flakes upward between runs the row will red again and should be bumped with a fresh measurement, not padded speculatively.