home-mixer: stop ads brand-safety from demoting organic rank - #17
Closed
Pitchfork-and-Torch wants to merge 19 commits into
Closed
home-mixer: stop ads brand-safety from demoting organic rank#17Pitchfork-and-Torch wants to merge 19 commits into
Pitchfork-and-Torch wants to merge 19 commits into
Conversation
in_network_ids is passed to the VF client without deduplication, while oon_ids is deduped four lines below. retweeted_tweet_id is pushed for every candidate that has one, so the same ID repeats once per retweet of a given post — most often when that post is going viral. Neither VfClient implementation dedupes its input: StratoVfClient builds one call per element, and XaiVfClient chunks by XAI_VF_MAX_BATCH_SIZE, so duplicates consume batch slots and can force an extra round trip. Not a correctness issue — results collapse into a HashMap keyed by tweet ID — but redundant work on the For You serving path. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Deduplicate in_network_ids before VF lookup
Rebased onto latest xai-org/x-algorithm main. Missed ads-VF hydration defaulted organics to MediumRisk, and ads-only nsfw_author_ads rewrote the shared verdict. Default For You blender then pulled those posts out of ranked order when placing ads. Keep a real MediumRisk tweet-label verdict off ad neighbors. Following still will not sit an ad next to Unspecified. Compatibility with sibling PRs that touch the same files: - expired ads brand-safety labels are ignored (xai-org#124) - gizmoduck uses origin author size/NSFW OR and fails closed on miss (xai-org#125) Co-authored-by: Jon Bailey <Pitchfork-and-Torch@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/ads-organic-verdict-leak-e878
branch
from
September 7, 2026 04:17
9a964e1 to
3029dc4
Compare
Pitchfork-and-Torch
marked this pull request as ready for review
September 7, 2026 04:31
Owner
Author
|
Wrong base (fork PR). Ship vehicle is upstream xai-org#127. Per submit law: never PR Pitchfork-and-Torch/x-algorithm. Do not merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Ads brand-safety was leaking into organic For You rank.
Two writers put MediumRisk on organics that were not MediumRisk from tweet labels:
brand_safety_verdictunset. Scored-post converters then defaulted that to MediumRisk.nsfw_author_adsis ads inventory. AdsBrandSafetyVfHydrator wrote that onto the shared verdict the blender uses for organics.Default For You blender (
partition_organic) treats MediumRisk as avoid and pulls those posts out of ranked order when ads are placed.Fix
has_avoid, so rank is kept.nsfw_author_adsno longer rewrites the organic verdict.Rebase
This branch is now a clean rebase onto latest
xai-org/x-algorithmmain(902a06f), not the older fork tree.Canonical upstream PR: xai-org#127
Conflict resolution keeps all three intents:
is_active_label/compute_verdict_at) — same class as home-mixer: ignore expired safety labels in ads brand safety xai-org/x-algorithm#124 / fork home-mixer: ignore expired safety labels in ads brand safety #13.nsfw_author_adsdoes not rewrite the organic verdict — home-mixer: stop ads brand-safety from demoting organic rank xai-org/x-algorithm#127.Not a TimelineHome VF change.